Uh oh!
There was an error while loading. Please reload this page.
build: add GN configurations for simdjson - #50831
Merged
Merged
Conversation
This was referenced Nov 21, 2023
Contributor
Fast-track has been requested by @kvakil. Please 👍 to approve. |
nodejs-github-bot
commented
Nov 21, 2023
Collaborator
marco-ippolito
approved these changes
Nov 21, 2023
anonrig
approved these changes
Nov 21, 2023
nodejs-github-bot
commented
Nov 21, 2023
Collaborator
nodejs-github-bot
commented
Nov 21, 2023
Collaborator
Landed in 1858341 |
targos pushed a commit
that referenced
this pull request
Nov 23, 2023
PR-URL: #50831 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
lucshi pushed a commit
to lucshi/node
that referenced
this pull request
Nov 27, 2023
PR-URL: nodejs#50831 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Merged
RafaelGSS pushed a commit
that referenced
this pull request
Nov 29, 2023
PR-URL: #50831 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
UlisesGascon pushed a commit
that referenced
this pull request
Dec 11, 2023
PR-URL: #50831 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Merged
UlisesGascon pushed a commit
that referenced
this pull request
Dec 13, 2023
PR-URL: #50831 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
UlisesGascon pushed a commit
that referenced
this pull request
Dec 15, 2023
PR-URL: #50831 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
UlisesGascon pushed a commit
that referenced
this pull request
Dec 19, 2023
PR-URL: #50831 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the GN build after the change in #50322.
Would appreciate a fast track merge to bring GN build back to green, so we can continue monitoring if anything breaks on main branch. /cc @anonrig