Skip to content

src: assert return value of BN_bn2binpad - #50860

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:src-crypto-random-bn2binpad-ret
Nov 25, 2023
Merged

src: assert return value of BN_bn2binpad#50860
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:src-crypto-random-bn2binpad-ret

Conversation

@tniessen

@tniessentniessen commented Nov 23, 2023

Copy link
Copy Markdown
Member

Every other invocation of BN_bn2binpad checks the return value. For safety and consistency, do so in RandomPrimeTraits::EncodeOutput() as well.

@tniessen
src: assert return value of BN_bn2binpad
a9ed260
Every other invocation of BN_bn2binpad checks the return value. For
safety and consistency, do so in RandomPrimeTraits::EncodeOutput()
as well.
@nodejs-github-bot

nodejs-github-bot commented Nov 23, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Nov 23, 2023
@panvapanva added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2023
@panvapanva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 23, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Nov 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55899/

@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 25, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 25, 2023
@nodejs-github-bot
nodejs-github-bot merged commit ed5cb37 into nodejs:mainNov 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in ed5cb37

lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@tniessenLei Shi
src: assert return value of BN_bn2binpad
a24623e
Every other invocation of BN_bn2binpad checks the return value. For
safety and consistency, do so in RandomPrimeTraits::EncodeOutput()
as well.
PR-URL: nodejs#50860
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Nov 27, 2023
@tniessen@RafaelGSS
src: assert return value of BN_bn2binpad
9bbc300
Every other invocation of BN_bn2binpad checks the return value. For
safety and consistency, do so in RandomPrimeTraits::EncodeOutput()
as well.
PR-URL: #50860
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Nov 28, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@tniessen@RafaelGSS
src: assert return value of BN_bn2binpad
feb8ff9
Every other invocation of BN_bn2binpad checks the return value. For
safety and consistency, do so in RandomPrimeTraits::EncodeOutput()
as well.
PR-URL: #50860
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@tniessen@UlisesGascon
src: assert return value of BN_bn2binpad
4c079f5
Every other invocation of BN_bn2binpad checks the return value. For
safety and consistency, do so in RandomPrimeTraits::EncodeOutput()
as well.
PR-URL: #50860
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
@tniessen@UlisesGascon
src: assert return value of BN_bn2binpad
8811eca
Every other invocation of BN_bn2binpad checks the return value. For
safety and consistency, do so in RandomPrimeTraits::EncodeOutput()
as well.
PR-URL: #50860
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
@tniessen@UlisesGascon
src: assert return value of BN_bn2binpad
8109ff5
Every other invocation of BN_bn2binpad checks the return value. For
safety and consistency, do so in RandomPrimeTraits::EncodeOutput()
as well.
PR-URL: #50860
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@tniessen@UlisesGascon
src: assert return value of BN_bn2binpad
07a4e94
Every other invocation of BN_bn2binpad checks the return value. For
safety and consistency, do so in RandomPrimeTraits::EncodeOutput()
as well.
PR-URL: #50860
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panvapanvapanva approved these changes
@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tniessen@nodejs-github-bot@panva@lpinca