Skip to content

benchmark: update iteration and size in benchmark/crypto/randomBytes.js - #50868

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
lucshi:my-branch-4
Dec 9, 2023
Merged

benchmark: update iteration and size in benchmark/crypto/randomBytes.js#50868
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
lucshi:my-branch-4

Conversation

@lucshi

@lucshilucshi commented Nov 23, 2023•
edited
Loading

Copy link
Copy Markdown

Increase iteration value from 1000 to 10000 to reflect real performance of randomBytes generation. The randomInt has no need to apply this.

Fixes: #50571

Below is the score improvment measured on cascadelake server:

crypto/randomBytes.js size=64: n=10000 percent=137.85%
crypto/randomBytes.js size=1024: n=10000 percent=130.66%
crypto/randomBytes.js size=8192: n=10000 percent=136.31%
crypto/randomBytes.js size=524288: n=10000 percent=166.50%

@nodejs-github-botnodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. crypto Issues and PRs related to the crypto subsystem. labels Nov 23, 2023
@lucshi

lucshi commented Nov 24, 2023

Copy link
Copy Markdown
Author

Test ASan should not fail.

H4ad
H4ad requested changes Nov 26, 2023
View reviewed changes
Comment threadbenchmark/crypto/randomBytes.js Outdated
Comment threadbenchmark/crypto/randomBytes.js Outdated
@H4ad

H4ad commented Nov 26, 2023

Copy link
Copy Markdown
Member

Test ASan should not fail.

No worries, I can restart later, sometimes it fails for no reason.

Also, can you update the first commit message to be similar to: Septa2112@a13bb22

@lucshilucshi changed the title benchmark: increase iteration of randomBytes case to appropriate onebenchmark: update iteration and size in benchmark/crypto/randomBytes.jsNov 27, 2023
@lucshi

lucshi commented Nov 27, 2023

Copy link
Copy Markdown
Author

Test ASan should not fail.

No worries, I can restart later, sometimes it fails for no reason.

Also, can you update the first commit message to be similar to: Septa2112@a13bb22

Done.

H4ad
H4ad approved these changes Dec 2, 2023
View reviewed changes

@H4adH4ad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with just a little fix on linter.

Comment threadbenchmark/crypto/randomBytes.js Outdated
Lei Shi@H4ad
Update benchmark/crypto/randomBytes.js
971746f
Co-authored-by: Vinicius Lourenço <12551007+H4ad@users.noreply.github.com>
@H4adH4ad added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 9, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 9, 2023
@nodejs-github-bot
nodejs-github-bot merged commit e158b11 into nodejs:mainDec 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 9, 2023

Copy link
Copy Markdown
Collaborator

Landed in e158b11

RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
Lei Shi@RafaelGSS
benchmark: update iteration and size in benchmark/crypto/randomBytes.js
53b16c7
Fixes: #50571
PR-URL: #50868
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Dec 15, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
Lei Shi@richardlau
benchmark: update iteration and size in benchmark/crypto/randomBytes.js
278c990
Fixes: #50571
PR-URL: #50868
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@H4adH4adH4ad approved these changes

Assignees

No one assigned

Labels

benchmarkIssues and PRs related to the benchmark subsystem.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.cryptoIssues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The performance gap between node16 and node21 changes as the n of the benchmark changes

4 participants

@lucshi@H4ad@nodejs-github-bot@jasnell