Uh oh!
There was an error while loading. Please reload this page.
src: remove unused headers in node_file.cc - #50927
Merged
Merged
Conversation
arxngr
reviewed
Nov 27, 2023
Contributor
There was a problem hiding this comment.
why this is removed? what if the compiler is using MinGW? it will miss something from io.h, or is some library already included from another header file?
ContributorAuthor
There was a problem hiding this comment.
Headers declared in .cc file are used internally only within the .cc file.
This code was added in the commit below.
bce41fa#diff-70e3325bd2115867617ae2a16321c5de53c070ff2841976fe5b849675a5111e6
At that time, there was code that was used internally to define __MINGW32__ and _MSC_VER, but it is no longer present.
nodejs-github-bot
commented
Nov 27, 2023
Collaborator
plurisforce-pushed
the
fix/remove_unused_header
branch
from
November 27, 2023 13:53
77b7761 to
4a1e1baComparenodejs-github-bot
commented
Nov 28, 2023
Collaborator
lpinca
approved these changes
Dec 4, 2023
nodejs-github-bot
commented
Dec 10, 2023
Collaborator
Landed in a768d89 |
RafaelGSS pushed a commit
that referenced
this pull request
Dec 15, 2023
PR-URL: #50927 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
richardlau pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #50927 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have cleaned up unused headers in
node_file.cc.