Skip to content

doc: add procedure when CVEs don't get published - #50945

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RafaelGSS:doc-update-cve-request
Nov 29, 2023
Merged

doc: add procedure when CVEs don't get published#50945
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RafaelGSS:doc-update-cve-request

Conversation

@RafaelGSS

Copy link
Copy Markdown
Member

This was the workaround provided by HackerOne team

Ref: nodejs/security-wg#1058

cc: @mhdawson

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 27, 2023

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working this out and documenting it.

Comment threaddoc/contributing/security-release-process.md Outdated
Comment threaddoc/contributing/security-release-process.md Outdated
This was the workaround provided by HackerOne team

@tniessentniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rafael!

@RafaelGSSRafaelGSS added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 29, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 29, 2023
@nodejs-github-bot
nodejs-github-bot merged commit fe98734 into nodejs:mainNov 29, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in fe98734

targos pushed a commit that referenced this pull request Dec 4, 2023
This was the workaround provided by HackerOne team
PR-URL: #50945
Refs: nodejs/security-wg#1058
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targostargos mentioned this pull request Dec 4, 2023
richardlau pushed a commit that referenced this pull request Mar 25, 2024
This was the workaround provided by HackerOne team
PR-URL: #50945
Refs: nodejs/security-wg#1058
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@RafaelGSS@nodejs-github-bot@benjamingr@tniessen@mhdawson@aymen94