Uh oh!
There was an error while loading. Please reload this page.
doc: Correct note on behavior of stats.isDirectory - #50946
Merged
Conversation
lpinca
approved these changes
Nov 29, 2023
Uh oh!
There was an error while loading. Please reload this page.
aymen94
approved these changes
Nov 30, 2023
watilde
approved these changes
Dec 1, 2023
jasnell
approved these changes
Dec 9, 2023
lpinca
commented
Dec 15, 2023
Member
Can you please fix the first commit message so that it adheres to our commit message guidelines? Thank you. |
NReilingh
commented
Dec 17, 2023
ContributorAuthor
@lpinca Is there a way to do that through GitHub, or does this require force-pushing new commits? |
lpinca
commented
Dec 17, 2023
Member
It requires force pushing. |
NReilingh
commented
Dec 17, 2023
ContributorAuthor
@lpinca Okay -- unless I've misunderstood the lint, this should be OK now. |
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
NReilingh
commented
Dec 18, 2023
ContributorAuthor
Trying again. |
lpinca
approved these changes
Dec 18, 2023
nodejs-github-bot
commented
Dec 18, 2023
Collaborator
Landed in 135948d |
RafaelGSS pushed a commit
that referenced
this pull request
Jan 2, 2024
PR-URL: #50946 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
richardlau pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #50946 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original author incorrectly assumed that lstat can only be used on symbolic links
The note incorrectly stated that
.isDirectory()always returns false when the stats object was obtained fromfs.lstat().lstatcan be used on any type of object -- not just symbolic links. When stats are obtained using lstat for a regular directory (not a link),.isDirectory()will return true.