Skip to content

http: handle multi-value content-disposition header correctly - #50977

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
ArsalanDotMe:content-disposition-multi-value
Dec 11, 2023
Merged

http: handle multi-value content-disposition header correctly#50977
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
ArsalanDotMe:content-disposition-multi-value

Conversation

@ArsalanDotMe

@ArsalanDotMeArsalanDotMe commented Nov 30, 2023

Copy link
Copy Markdown
Contributor

This change fixes a bug introduced by an earlier PR #46528. Basically, in the earlier PR the code was written with the assumption that content-disposition header will always have a scalar string value but in fact Node.js allows users to provide an array as a value for a header.

If you provide an array value for content-disposition header, then the Buffer string would contain characters that are invalid for headers and that results in a ERR_INVALID_HTTP_RESPONSE error.

@nodejs-github-bot

nodejs-github-bot commented Nov 30, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-botnodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Nov 30, 2023
@ArsalanDotMeArsalanDotMe changed the title Handle multi-value content-disposition header correctlyhttp: handle multi-value content-disposition header correctlyNov 30, 2023
@ArsalanDotMe

ArsalanDotMe commented Nov 30, 2023

Copy link
Copy Markdown
ContributorAuthor

Fixes #50978

@ArsalanDotMe

ArsalanDotMe commented Dec 1, 2023

Copy link
Copy Markdown
ContributorAuthor

@ShogunPanda@mcollina tagging you to get your eyes on this since you reviewed the related PR before. This change is important because in some libraries, headers are always passed as arrays (usually single value) to response.setHeader. Everything else works fine that way but content-disposition fails in an unexpected manner.

@ArsalanDotMeArsalanDotMe mentioned this pull request Dec 1, 2023
Merged
@marco-ippolito

marco-ippolito commented Dec 1, 2023

Copy link
Copy Markdown
Member

@ArsalanDotMe can you amend commit message, the ci is failing

@ArsalanDotMe
http: handle multi-value content-disposition header
5e6d348
Headers in nodejs can be arrays and current workaround for
content-disposition header do not take this into account.
This change fixes that and makes sure array values are handled
properly.
@ArsalanDotMe

ArsalanDotMe commented Dec 1, 2023

Copy link
Copy Markdown
ContributorAuthor

yes, sure. just a sec

ShogunPanda
ShogunPanda approved these changes Dec 6, 2023
View reviewed changes

@ShogunPandaShogunPanda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marco-ippolitomarco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56132/

@nodejs-github-bot

nodejs-github-bot commented Dec 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56134/

@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56197/

mcollina
mcollina approved these changes Dec 10, 2023
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56203/

@nodejs-github-bot

nodejs-github-bot commented Dec 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56215/

@mcollinamcollina added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed needs-ci PRs that need a full CI run. labels Dec 11, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 11, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 6e90fed into nodejs:mainDec 11, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 11, 2023

Copy link
Copy Markdown
Collaborator

Landed in 6e90fed

@steelbrainsteelbrain mentioned this pull request Dec 12, 2023
Open
RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
@ArsalanDotMe@RafaelGSS
http: handle multi-value content-disposition header
7f95926
Headers in nodejs can be arrays and current workaround for
content-disposition header do not take this into account.
This change fixes that and makes sure array values are handled
properly.
PR-URL: #50977
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Dec 15, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@ArsalanDotMe@richardlau
http: handle multi-value content-disposition header
4e38dee
Headers in nodejs can be arrays and current workaround for
content-disposition header do not take this into account.
This change fixes that and makes sure array values are handled
properly.
PR-URL: #50977
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Merged
@geirbak

geirbak commented Jun 13, 2024

Copy link
Copy Markdown

I'm not sure where/how is the correct way for me to raise this, but we need this fixed in the 18 LTS (It was introduced in 18.16.0 - #46528).

@einarq

einarq commented Jun 19, 2024

Copy link
Copy Markdown

I'm not sure where/how is the correct way for me to raise this, but we need this fixed in the 18 LTS (It was introduced in 18.16.0 - #46528).

@richardlau
Planning on merging this for 18 as well?

@richardlau

richardlau commented Jun 19, 2024•
edited
Loading

Copy link
Copy Markdown
Member

I've added the lts-watch-v18.x label to this which will put it on the list of things to consider for the next non-security Node.js 18.x release.

@einarq

einarq commented Jun 19, 2024

Copy link
Copy Markdown

I've added the lts-watch-v18.x label to this which will put it on the list of things to consider for the next non-security Node.js 18.x release.

Ok, thanks. We will have to ask people to downgrade to 18.5 in the meantime.

richardlau pushed a commit that referenced this pull request Jul 19, 2024
@ArsalanDotMe@richardlau
http: handle multi-value content-disposition header
0092358
Headers in nodejs can be arrays and current workaround for
content-disposition header do not take this into account.
This change fixes that and makes sure array values are handled
properly.
PR-URL: #50977
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@geirbakgeirbak mentioned this pull request Jul 29, 2024
Closed
@aduh95aduh95 mentioned this pull request Nov 7, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@ShogunPandaShogunPandaShogunPanda approved these changes
@jasnelljasnelljasnell approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.httpIssues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@ArsalanDotMe@nodejs-github-bot@marco-ippolito@geirbak@einarq@richardlau@mcollina@ShogunPanda@jasnell