Skip to content

test: escape cwd in regexp - #50980

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
kapouer:patch-5
Dec 5, 2023
Merged

test: escape cwd in regexp#50980
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
kapouer:patch-5

Conversation

@kapouer

@kapouerkapouer commented Nov 30, 2023

Copy link
Copy Markdown
Contributor

Some signs in cwd could make this regexp fail

@nodejs-github-bot

nodejs-github-bot commented Nov 30, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 30, 2023
@kapouerkapouer changed the title [test] Escape cwd in regexptest: Escape cwd in regexpNov 30, 2023
aduh95
aduh95 reviewed Nov 30, 2023
View reviewed changes
Comment threadtest/parallel/test-runner-output.mjs Outdated
@kapouerkapouer changed the title test: Escape cwd in regexptest: escape cwd in regexpNov 30, 2023
@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 1, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 1, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56039/

MoLow
MoLow approved these changes Dec 3, 2023
View reviewed changes

@MoLowMoLow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, need to revert @aduh95 's suggestion since it uses common js

@kapouer@aduh95
test: escape cwd in regexp
46a30e6
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 4, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 4, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56086/

@nodejs-github-bot

nodejs-github-bot commented Dec 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56089/

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 5, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 5, 2023
@nodejs-github-bot
nodejs-github-bot merged commit fba2c93 into nodejs:mainDec 5, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 5, 2023

Copy link
Copy Markdown
Collaborator

Landed in fba2c93

RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
@kapouer@aduh95@RafaelGSS
test: escape cwd in regexp
4ddd0da
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #50980
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Dec 15, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@kapouer@aduh95@richardlau
test: escape cwd in regexp
a4f1805
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #50980
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr approved these changes
@lpincalpincalpinca approved these changes
@MoLowMoLowMoLow approved these changes
@aduh95aduh95aduh95 approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@kapouer@nodejs-github-bot@benjamingr@lpinca@MoLow@aduh95@atlowChemi