test_runner: fixed test object is incorrectly passed to setup() by pulkit-30 · Pull Request #50982 · nodejs/node

pulkit-30 · 2023-11-30T18:04:41Z

Fix#48809

pass testStream to setup instead testRoot.

nodejs-github-bot · 2023-11-30T18:04:47Z

Review requested:

@nodejs/test_runner

rluvaton

Can you please add a test

rluvaton

Well done! thanks

nodejs-github-bot · 2023-12-04T15:13:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56073/

MoLow

this PR causes a regression:
running a simple test file:

consttest=require("node:test");test("a",()=>console.log(1));

on main console is printed with colors

but on this branch the colors are discarded:

I am working on fixing the test that should have caught this

pulkit-30 · 2023-12-06T01:42:17Z

this PR causes a regression:
running a simple test file:

I was also suspecting something, but surprised by the tests 😅

pulkit-30 · 2023-12-06T01:51:03Z

converting this PR to draft. ref: #51064, still working on it 🚀

MoLow

createWriteStream is called multiple times for each reporter destination, and in some cases the writeStream is never being closed

pulkit-30 · 2023-12-23T16:34:25Z

@MoLow PTAL.

nodejs-github-bot · 2023-12-23T22:00:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56498/

nodejs-github-bot · 2023-12-24T07:10:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56508/

nodejs-github-bot · 2023-12-24T08:23:56Z

Landed in dad666a

MoLow · 2023-12-24T09:18:30Z

@pulkit-30 thanks for the hard work 🎉

pulkit-30 · 2023-12-24T15:44:30Z

@pulkit-30 thanks for the hard work 🎉

Thanks a ton! It means a lot.

PR-URL: #50982 Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

koshic · 2024-01-16T13:03:17Z

@MoLow do you plan to backport it to 20.x? Documentation is still incorrect - https://nodejs.org/docs/latest-v20.x/api/test.html#runoptions.

MoLow · 2024-01-16T19:13:19Z

not every PR needs a manual backport. lets wait for @nodejs/releasers to release a new v20 version and request a backport if needed

PR-URL: #50982 Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Nov 30, 2023

pulkit-30 commented Nov 30, 2023
View reviewed changes

Comment threadlib/internal/test_runner/utils.js Outdated

pulkit-30 marked this pull request as ready for review December 3, 2023 12:36

rluvaton reviewed Dec 3, 2023
View reviewed changes

pulkit-30 requested a review from rluvaton December 4, 2023 04:38

rluvaton reviewed Dec 4, 2023
View reviewed changes

Comment threadtest/parallel/test-runner-run.mjs Outdated

rluvaton reviewed Dec 4, 2023
View reviewed changes

Comment threadtest/parallel/test-runner-run.mjs Outdated

pulkit-30 force-pushed the fix-48809 branch from 4086899 to 7513467Compare December 4, 2023 11:08

rluvaton reviewed Dec 4, 2023
View reviewed changes

Comment threadtest/parallel/test-runner-run.mjs Outdated

rluvaton approved these changes Dec 4, 2023
View reviewed changes

rluvaton added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 4, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 4, 2023

pulkit-30 requested a review from MoLow December 4, 2023 15:29

MoLow requested changes Dec 5, 2023
View reviewed changes

MoLow mentioned this pull request Dec 5, 2023
test: fix test runner colored output test #51064
Merged

pulkit-30 marked this pull request as draft December 6, 2023 01:51

pulkit-30 force-pushed the fix-48809 branch from 3c8c335 to 79d22e5Compare December 6, 2023 17:01

pulkit-30 marked this pull request as ready for review December 6, 2023 17:01

pulkit-30 requested a review from MoLow December 11, 2023 15:49

pulkit-30 force-pushed the fix-48809 branch from 79d22e5 to 6a3ebf7Compare December 11, 2023 15:51

MoLow reviewed Dec 11, 2023
View reviewed changes

Comment threadtest/parallel/test-runner-run.mjs Outdated

MoLow reviewed Dec 11, 2023
View reviewed changes

Comment threadlib/internal/test_runner/utils.js Outdated

MoLow requested changes Dec 11, 2023
View reviewed changes

test_runner: fixed test object is incorrectly passed to setup()
e4eb26b

fix suggestions
175af14

pulkit-30 force-pushed the fix-48809 branch from 6a3ebf7 to 175af14Compare December 12, 2023 10:57

pulkit-30 added 2 commits December 12, 2023 16:30

fix lint
775ea08

call colorizeTestFil fn before abort
9f64e75

MoLow reviewed Dec 12, 2023
View reviewed changes

Comment threadlib/internal/test_runner/utils.js Outdated

MoLow reviewed Dec 12, 2023
View reviewed changes

Comment threadlib/internal/test_runner/harness.js Outdated

MoLow reviewed Dec 12, 2023
View reviewed changes

Comment threadlib/internal/test_runner/runner.js Outdated

fix suggestions
ca75b72

pulkit-30 requested a review from MoLow December 15, 2023 16:50

MoLow approved these changes Dec 23, 2023
View reviewed changes

MoLow added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 23, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2023

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 24, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 24, 2023

nodejs-github-bot merged commit dad666a into nodejs:mainDec 24, 2023

RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
test_runner: fixed test object is incorrectly passed to setup()
979cebc
PR-URL: #50982 Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

RafaelGSS mentioned this pull request Jan 2, 2024
v21.6.0 proposal #51342
Merged

richardlau pushed a commit that referenced this pull request Mar 25, 2024
test_runner: fixed test object is incorrectly passed to setup()
34ecd1e
PR-URL: #50982 Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

richardlau mentioned this pull request Mar 25, 2024
v20.12.0 proposal #52212
Merged

Uh oh!

Uh oh!

Conversation

pulkit-30 commented Nov 30, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Nov 30, 2023

Uh oh!

Uh oh!

rluvaton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rluvaton left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Dec 4, 2023

Uh oh!

MoLow left a comment

Choose a reason for hiding this comment

Uh oh!

pulkit-30 commented Dec 6, 2023

Uh oh!

pulkit-30 commented Dec 6, 2023

Uh oh!

Uh oh!

Uh oh!

MoLow left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pulkit-30 commented Dec 23, 2023

Uh oh!

nodejs-github-bot commented Dec 23, 2023

Uh oh!

nodejs-github-bot commented Dec 24, 2023

Uh oh!

nodejs-github-bot commented Dec 24, 2023

Uh oh!

MoLow commented Dec 24, 2023

Uh oh!

pulkit-30 commented Dec 24, 2023

Uh oh!

koshic commented Jan 16, 2024

Uh oh!

MoLow commented Jan 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pulkit-30 commented Nov 30, 2023•
edited
Loading