Skip to content

test: set dns-resolveany-bad-ancount timeout - #50995

Closed
kapouer wants to merge 3 commits into
nodejs:mainfrom
kapouer:patch-6
Closed

test: set dns-resolveany-bad-ancount timeout#50995
kapouer wants to merge 3 commits into
nodejs:mainfrom
kapouer:patch-6

Conversation

@kapouer

Copy link
Copy Markdown
Contributor

Some build environments just hang forever.

Some build environments just hang forever
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 1, 2023
@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 1, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 1, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@kapouer

Copy link
Copy Markdown
ContributorAuthor

Those changes don't make any sense, the server should respond right away in that test.
Something else is happening, closing.

@kapouerkapouer closed this Dec 2, 2023
@lpinca

Copy link
Copy Markdown
Member

@kapouer they does, malformed responses are discarded in c-ares >= 1.21.0. See #50741. The same issue is blocking #50800. I think it makes sense to completely remove the test.

@kapouer

Copy link
Copy Markdown
ContributorAuthor

Yes, but setting the timeout as in this PR does not work at all.

@lpinca

lpinca commented Dec 3, 2023

Copy link
Copy Markdown
Member

The only problem I actually see in this PR is the retry option name. It is called tries. I think that if you use the correct name it works.

You might also wonder why setting a timeout is required. The default one is two seconds. The problem is that after c-ares/c-ares@3b10e57 using -1 for the default timeout no longer works. As per our documentation we pass -1 but that is casted to an unsigned int (4294967295). This is an issue we should address before updating c-ares to version >= 1.21.0.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kapouer@nodejs-github-bot@lpinca