Skip to content

deps: update simdjson to 3.6.3 - #51104

Closed
nodejs-github-bot wants to merge 1 commit into
mainfrom
actions/tools-update-simdjson
Closed

deps: update simdjson to 3.6.3#51104
nodejs-github-bot wants to merge 1 commit into
mainfrom
actions/tools-update-simdjson

Conversation

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

This is an automated update of simdjson to 3.6.3.

@nodejs-github-botnodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Dec 10, 2023
@mhdawson

Copy link
Copy Markdown
Member

@marco-ippolito we may need to run a step in the updater to run the formatter so the linter does not complain.

@marco-ippolito

This comment was marked as outdated.

@marco-ippolito

marco-ippolito commented Dec 16, 2023

Copy link
Copy Markdown
Member

So actually there is an issue with the maintaining dependencies script, there was a typo, that's why its failing
Refs: #51177

@aduh95
aduh95force-pushed the actions/tools-update-simdjson branch from 949c587 to f9aaf46CompareDecember 17, 2023 00:32
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 17, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 17, 2023
@nodejs-github-bot

Copy link
Copy Markdown
CollaboratorAuthor

@nodejs-github-bot

Copy link
Copy Markdown
CollaboratorAuthor

@nodejs-github-bot

Copy link
Copy Markdown
CollaboratorAuthor

@nodejs-github-bot

Copy link
Copy Markdown
CollaboratorAuthor

@nodejs-github-bot

Copy link
Copy Markdown
CollaboratorAuthor

@aduh95
aduh95force-pushed the actions/tools-update-simdjson branch from f9aaf46 to f731246CompareDecember 19, 2023 10:08
@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2023
@nodejs-github-bot

Copy link
Copy Markdown
CollaboratorAuthor

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson pushed a commit that referenced this pull request Dec 20, 2023
PR-URL: #51104
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@mhdawson

Copy link
Copy Markdown
Member

Landed in e7d90c5

@targos
targos deleted the actions/tools-update-simdjson branch December 23, 2023 10:24
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
PR-URL: #51104
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@RafaelGSSRafaelGSS mentioned this pull request Jan 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.dependenciesPull requests that update a dependency file.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@nodejs-github-bot@mhdawson@marco-ippolito@UlisesGascon@aduh95