Uh oh!
There was an error while loading. Please reload this page.
[v20.x backport] fs: add stacktrace to fs/promises - #51127
Closed
sapphi-red wants to merge 1 commit into
Closed
Conversation
sapphi-redforce-pushed
the
backport-49849-to-v20.x
branch
from
December 12, 2023 05:25
119b5ee to
3a1ee22Comparesapphi-red
commented
Dec 12, 2023
ContributorAuthor
The lint error is not caused by this PR. |
UlisesGasconforce-pushed
the
v20.x-staging
branch
from
December 12, 2023 09:33
a300366 to
423c757CompareUlisesGascon
commented
Dec 12, 2023
Member
The lint issue was solved in c519e80 🙌 |
sapphi-redforce-pushed
the
backport-49849-to-v20.x
branch
from
December 12, 2023 13:17
3a1ee22 to
61766a7Comparesapphi-red
commented
Dec 12, 2023
ContributorAuthor
Rebased on top of it 👍 |
UlisesGasconforce-pushed
the
v20.x-staging
branch
2 times, most recently
from
December 15, 2023 18:47
7ee5261 to
4c9099fCompareUlisesGasconforce-pushed
the
v20.x-staging
branch
from
December 20, 2023 15:15
4c9099f to
7af8e20CompareUlisesGasconforce-pushed
the
v20.x-staging
branch
from
January 9, 2024 08:44
a42629c to
435f9c9Comparerichardlau
commented
Mar 25, 2024
Member
This needs to be rebased. |
sapphi-redforce-pushed
the
backport-49849-to-v20.x
branch
from
March 26, 2024 04:54
61766a7 to
c4d58e7CompareSync functions in fs throwed an error with a stacktrace which is helpful for debugging. But functions in fs/promises throwed an error without a stacktrace. This commit adds stacktraces by calling Error.captureStacktrace and re-throwing the error. Refs: nodejs#34817 PR-URL: nodejs#49849 Backport-PR-URL: nodejs#51127Fixes: nodejs#50160 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
sapphi-redforce-pushed
the
backport-49849-to-v20.x
branch
from
March 26, 2024 04:54
c4d58e7 to
518d819Comparenodejs-github-bot
commented
Mar 26, 2024
Collaborator
nodejs-github-bot
commented
Mar 28, 2024
Collaborator
nodejs-github-bot
commented
Mar 29, 2024
Collaborator
marco-ippolito
approved these changes
Apr 29, 2024
marco-ippolitoforce-pushed
the
v20.x-staging
branch
from
April 29, 2024 13:22
4fd1691 to
ecadd63CompareRafaelGSS
approved these changes
Apr 29, 2024
marco-ippolito pushed a commit
that referenced
this pull request
Apr 29, 2024
Sync functions in fs throwed an error with a stacktrace which is helpful for debugging. But functions in fs/promises throwed an error without a stacktrace. This commit adds stacktraces by calling Error.captureStacktrace and re-throwing the error. Refs: #34817 PR-URL: #49849 Backport-PR-URL: #51127Fixes: #50160 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
marco-ippolito
commented
Apr 29, 2024
Member
Landed in c530520 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a backport of #49849.
Sync functions in fs throwed an error with a stacktrace which is helpful for debugging. But functions in fs/promises throwed an error without a stacktrace. This commit adds stacktraces by calling Error.captureStacktrace and re-throwing the error.
Refs: #34817
PR-URL: #49849
Fixes: #50160
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Zeyu "Alex" Yang himself65@outlook.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il
Reviewed-By: Jiawen Geng technicalcute@gmail.com