Uh oh!
There was an error while loading. Please reload this page.
stream: fix deadlock when cloning webstreams - #51131
Conversation
nodejs-github-bot
commented
Dec 13, 2023
aduh95
left a comment
There was a problem hiding this comment.
Can you amend the commit message so it matches our guidelines? using is not an imperative verb, I suggest something like stream: fix deadlock when cloning webstreams
node/doc/contributing/pull-requests.md
Lines 170 to 172 in 1149d6b
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Dec 19, 2023
tsctx
commented
Dec 20, 2023
There seems to be a problem with FinalizationRegistry, so please wait for that to be resolved. |
nodejs-github-bot
commented
Dec 20, 2023
tsctx
commented
Dec 21, 2023
jasnell
left a comment
There was a problem hiding this comment.
Appreciate the work on this but this isn't the correct fix. The issue is the fact that cloned ReadableStream and WritableStream instances use a MessageChannel under the covers to communicate. The MessagePorts for each need to be unref'd in order to allow the process to exit. I'll have an alternative PR opened shortly.
Fixes#44985.
Fixed a problem where the process would not terminate if structuredClone was used for webstream and body was not consumed.