Skip to content

doc: fix TestsStream parent class - #51181

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
pluris:doc/test_stream
Dec 18, 2023
Merged

doc: fix TestsStream parent class#51181
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
pluris:doc/test_stream

Conversation

@pluris

@plurispluris commented Dec 16, 2023•
edited by aduh95
Loading

Copy link
Copy Markdown
Contributor

As mentioned in the problem, the link was incorrect and has been fixed.

Fixes: #51174

@nodejs-github-bot

nodejs-github-bot commented Dec 16, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem. labels Dec 16, 2023
@lpinca

lpinca commented Dec 16, 2023

Copy link
Copy Markdown
Member

I understand why you added "link" in the commit message but it is a bit confusing. How about "fix TestsStrem parent class"?

@plurispluris changed the title doc: fix incorrect link for TestsStreamdoc: fix TestsStream parent classDec 16, 2023
@pluris

pluris commented Dec 16, 2023

Copy link
Copy Markdown
ContributorAuthor

@lpinca I think the commit message you suggested is clearer.
Thank you for the comment. I fixed it.

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 17, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 18, 2023
@nodejs-github-bot
nodejs-github-bot merged commit b931e61 into nodejs:mainDec 18, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 18, 2023

Copy link
Copy Markdown
Collaborator

Landed in b931e61

RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
Jungku Lee@RafaelGSS
doc: fix TestsStream parent class
1c71435
PR-URL: #51181Fixes: #51174
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@RafaelGSSRafaelGSS mentioned this pull request Jan 2, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
Jungku Lee@richardlau
doc: fix TestsStream parent class
184b8be
PR-URL: #51181Fixes: #51174
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@MoLowMoLowMoLow approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TestStream is a Node stream but docs link to web ReadableStream

6 participants

@pluris@nodejs-github-bot@lpinca@MoLow@atlowChemi@aduh95