Uh oh!
There was an error while loading. Please reload this page.
doc: mention native addons are restricted in pm - #51185
Merged
nodejs-github-bot merged 2 commits intoDec 19, 2023
Merged
Conversation
nodejs-github-bot
commented
Dec 16, 2023
Collaborator
Review requested:
|
marco-ippolito
approved these changes
Dec 16, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Tobias Nießen <tniessen@tnie.de>
nodejs-github-bot
commented
Dec 18, 2023
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/51185 ✔ Done loading data for nodejs/node/pull/51185 ----------------------------------- PR info ------------------------------------ Title doc: mention native addons are restricted in pm (#51185) Author Rafael Gonzaga (@RafaelGSS) Branch RafaelGSS:mention-addons-are-restricted -> nodejs:main Labels doc, author ready, permission Commits 2 - doc: mention native addons are restricted in pm - fixup! typo Committers 2 - RafaelGSS - GitHub PR-URL: https://github.com/nodejs/node/pull/51185 Reviewed-By: Marco Ippolito Reviewed-By: Michael Dawson ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51185 Reviewed-By: Marco Ippolito Reviewed-By: Michael Dawson -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 16 Dec 2023 16:26:17 GMT ✔ Approvals: 2 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/51185#pullrequestreview-1785242443 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/51185#pullrequestreview-1787536430 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 51185 From https://github.com/nodejs/node * branch refs/pull/51185/merge -> FETCH_HEAD ✔ Fetched commits as 135948d584ab..2483f9125ae2 -------------------------------------------------------------------------------- [main 354bade593] doc: mention native addons are restricted in pm Author: RafaelGSS Date: Sat Dec 16 13:25:34 2023 -0300 1 file changed, 1 insertion(+), 1 deletion(-) [main 7992aad966] fixup! typo Author: Rafael Gonzaga Date: Mon Dec 18 10:43:41 2023 -0300 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/7254037180 |
nodejs-github-bot
commented
Dec 19, 2023
Collaborator
Landed in 27d953d |
RafaelGSS added a commit
that referenced
this pull request
Jan 2, 2024
PR-URL: #51185 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
richardlau pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51185 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifying native addons are restricted by default when using the permission model.