deps: V8: cherry-pick de611e69ad51 by kvakil · Pull Request #51200 · nodejs/node

kvakil · 2023-12-18T03:05:17Z

This allows Maglev (see ref) to build on the compilers we use.

Original commit message:

[maglev] fix non-ptr-compr compilation on old compilers
When pointer compression is disabled, the preprocessor expands some
static asserts to static_assert(false), which doesn't compile on
compilers not implementing the C++ defect report CWG2518, notably clang
before version 17 and gcc before version 13.
Adding in part of the template parameter to the static assert prevents
it from being evaluated immediately which fixes the compilation.
Test: compiled with gcc-11 and clang-14 without pointer compression.
Change-Id: I95ce29bdb1278e6dad9e592d6f9476395f8aeb59
Fixed: v8:14355
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5022760
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#91553}

Refs: v8/v8@de611e6
Refs: #50690

nodejs-github-bot · 2023-12-18T03:05:23Z

Review requested:

@nodejs/gyp
@nodejs/v8-update

nodejs-github-bot · 2023-12-18T03:08:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56354/

nodejs-github-bot · 2023-12-18T03:08:34Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5720/

nodejs-github-bot · 2023-12-18T03:09:35Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5720/

nodejs-github-bot · 2023-12-18T03:11:30Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5720/

targos · 2023-12-18T07:11:47Z

This is not a cherry-pick

Original commit message: [maglev] fix non-ptr-compr compilation on old compilers When pointer compression is disabled, the preprocessor expands some static asserts to static_assert(false), which doesn't compile on compilers not implementing the C++ defect report CWG2518, notably clang before version 17 and gcc before version 13. Adding in part of the template parameter to the static assert prevents it from being evaluated immediately which fixes the compilation. Test: compiled with gcc-11 and clang-14 without pointer compression. Change-Id: I95ce29bdb1278e6dad9e592d6f9476395f8aeb59 Fixed: v8:14355 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5022760 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#91553} Refs: v8/v8@de611e6

kvakil · 2023-12-19T17:57:10Z

Fixed, thanks for noticing. I used git node v8 backport so I have no idea how that happened, but I should've been more diligent.

nodejs-github-bot · 2023-12-19T22:33:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56400/

nodejs-github-bot · 2023-12-19T22:33:18Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5727/

nodejs-github-bot · 2023-12-19T22:35:40Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5727/

nodejs-github-bot · 2023-12-19T22:38:11Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5727/

nodejs-github-bot · 2023-12-20T13:22:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56408/

nodejs-github-bot · 2023-12-21T17:44:21Z

Landed in f5c9599

Original commit message: [maglev] fix non-ptr-compr compilation on old compilers When pointer compression is disabled, the preprocessor expands some static asserts to static_assert(false), which doesn't compile on compilers not implementing the C++ defect report CWG2518, notably clang before version 17 and gcc before version 13. Adding in part of the template parameter to the static assert prevents it from being evaluated immediately which fixes the compilation. Test: compiled with gcc-11 and clang-14 without pointer compression. Change-Id: I95ce29bdb1278e6dad9e592d6f9476395f8aeb59 Fixed: v8:14355 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5022760 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#91553} Refs: v8/v8@de611e6 PR-URL: nodejs#51200 Refs: nodejs#50690 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

Original commit message: [maglev] fix non-ptr-compr compilation on old compilers When pointer compression is disabled, the preprocessor expands some static asserts to static_assert(false), which doesn't compile on compilers not implementing the C++ defect report CWG2518, notably clang before version 17 and gcc before version 13. Adding in part of the template parameter to the static assert prevents it from being evaluated immediately which fixes the compilation. Test: compiled with gcc-11 and clang-14 without pointer compression. Change-Id: I95ce29bdb1278e6dad9e592d6f9476395f8aeb59 Fixed: v8:14355 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5022760 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#91553} Refs: v8/v8@de611e6 PR-URL: #51200 Refs: #50690 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

Original commit message: [maglev] fix non-ptr-compr compilation on old compilers When pointer compression is disabled, the preprocessor expands some static asserts to static_assert(false), which doesn't compile on compilers not implementing the C++ defect report CWG2518, notably clang before version 17 and gcc before version 13. Adding in part of the template parameter to the static assert prevents it from being evaluated immediately which fixes the compilation. Test: compiled with gcc-11 and clang-14 without pointer compression. Change-Id: I95ce29bdb1278e6dad9e592d6f9476395f8aeb59 Fixed: v8:14355 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5022760 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#91553} Refs: v8/v8@de611e6 PR-URL: #51200 Refs: #50690 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> PR-URL: #50115 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

Original commit message: [maglev] fix non-ptr-compr compilation on old compilers When pointer compression is disabled, the preprocessor expands some static asserts to static_assert(false), which doesn't compile on compilers not implementing the C++ defect report CWG2518, notably clang before version 17 and gcc before version 13. Adding in part of the template parameter to the static assert prevents it from being evaluated immediately which fixes the compilation. Test: compiled with gcc-11 and clang-14 without pointer compression. Change-Id: I95ce29bdb1278e6dad9e592d6f9476395f8aeb59 Fixed: v8:14355 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5022760 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#91553} Refs: v8/v8@de611e6 PR-URL: nodejs#51200 Refs: nodejs#50690 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> PR-URL: nodejs#50115 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

Original commit message: [maglev] fix non-ptr-compr compilation on old compilers When pointer compression is disabled, the preprocessor expands some static asserts to static_assert(false), which doesn't compile on compilers not implementing the C++ defect report CWG2518, notably clang before version 17 and gcc before version 13. Adding in part of the template parameter to the static assert prevents it from being evaluated immediately which fixes the compilation. Test: compiled with gcc-11 and clang-14 without pointer compression. Change-Id: I95ce29bdb1278e6dad9e592d6f9476395f8aeb59 Fixed: v8:14355 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5022760 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#91553} Refs: v8/v8@de611e6 PR-URL: #51200 Refs: #50690 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Dec 18, 2023

kvakil added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 18, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 18, 2023

anonrig requested changes Dec 18, 2023
View reviewed changes

Comment threaddeps/v8/src/maglev/maglev-code-generator.cc Outdated

kvakil force-pushed the compile-maglev branch 2 times, most recently from 9452dc3 to 5f78ed1Compare December 19, 2023 17:55

kvakil requested a review from anonrig December 19, 2023 17:57

anonrig approved these changes Dec 19, 2023
View reviewed changes

anonrig requested a review from targos December 19, 2023 21:19

kvakil added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2023

targos approved these changes Dec 20, 2023
View reviewed changes

richardlau approved these changes Dec 20, 2023
View reviewed changes

UlisesGascon approved these changes Dec 20, 2023
View reviewed changes

debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 20, 2023

kvakil added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2023

nodejs-github-bot merged commit f5c9599 into nodejs:mainDec 21, 2023

targos mentioned this pull request Dec 22, 2023
deps: update V8 to 11.9 #50115
Closed

RafaelGSS mentioned this pull request Jan 2, 2024
v21.6.0 proposal #51342
Merged

richardlau mentioned this pull request Mar 25, 2024
v20.12.0 proposal #52212
Merged

Uh oh!

Uh oh!

Conversation

kvakil commented Dec 18, 2023

Uh oh!

nodejs-github-bot commented Dec 18, 2023

Uh oh!

nodejs-github-bot commented Dec 18, 2023

Uh oh!

nodejs-github-bot commented Dec 18, 2023

Uh oh!

nodejs-github-bot commented Dec 18, 2023

Uh oh!

nodejs-github-bot commented Dec 18, 2023

Uh oh!

targos commented Dec 18, 2023

Uh oh!

Uh oh!

kvakil commented Dec 19, 2023

Uh oh!

nodejs-github-bot commented Dec 19, 2023

Uh oh!

nodejs-github-bot commented Dec 19, 2023

Uh oh!

nodejs-github-bot commented Dec 19, 2023

Uh oh!

nodejs-github-bot commented Dec 19, 2023

Uh oh!

nodejs-github-bot commented Dec 20, 2023

Uh oh!

nodejs-github-bot commented Dec 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants