Uh oh!
There was an error while loading. Please reload this page.
deps: update c-ares to 1.25.0 - #51208
Conversation
nodejs-github-bot
commented
Dec 18, 2023
Review requested:
|
476b81e to
245caf3Compare245caf3 to
25d357bComparenodejs-github-bot
commented
Dec 19, 2023
nodejs-github-bot
commented
Dec 19, 2023
@nodejs/platform-aix can you help? I tried to work around c-ares/c-ares#668 by adding |
richardlau
commented
Dec 19, 2023
AIX doesn't have |
lpinca
commented
Dec 19, 2023
Yes, I understand, but I see no other way to work around the bug. I will remove the defines everywhere when the next c-ares release is cut. |
richardlau
commented
Dec 19, 2023
I think it makes sense to have those defines on platforms that have |
Ok, but I'm not sure if it is supported on all solaris versions. I think we should remove them there too. |
richardlau
commented
Dec 19, 2023
Well we have a team to ask re. that -- ping @nodejs/platform-smartos. |
lpinca
commented
Jan 5, 2024
Closed in favor of #51385. |
This is an automated update of c-ares to 1.25.0.