Skip to content

deps: update c-ares to 1.25.0 - #51208

Closed
nodejs-github-bot wants to merge 2 commits into
mainfrom
actions/tools-update-c-ares
Closed

deps: update c-ares to 1.25.0#51208
nodejs-github-bot wants to merge 2 commits into
mainfrom
actions/tools-update-c-ares

Conversation

@nodejs-github-bot

@nodejs-github-botnodejs-github-bot commented Dec 18, 2023

Copy link
Copy Markdown
Collaborator

This is an automated update of c-ares to 1.25.0.

@nodejs-github-botnodejs-github-bot added the dependencies Pull requests that update a dependency file. label Dec 18, 2023
@nodejs-github-bot

Copy link
Copy Markdown
CollaboratorAuthor

Review requested:

  • @nodejs/net

@nodejs-github-botnodejs-github-bot added cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run. labels Dec 18, 2023
@lpinca
lpincaforce-pushed the actions/tools-update-c-ares branch from 476b81e to 245caf3CompareDecember 19, 2023 10:16
@lpinca
lpincaforce-pushed the actions/tools-update-c-ares branch from 245caf3 to 25d357bCompareDecember 19, 2023 10:27
@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2023
@nodejs-github-bot

Copy link
Copy Markdown
CollaboratorAuthor

@nodejs-github-bot

Copy link
Copy Markdown
CollaboratorAuthor

@lpinca

lpinca commented Dec 19, 2023

Copy link
Copy Markdown
Member

@nodejs/platform-aix can you help? I tried to work around c-ares/c-ares#668 by adding #define HAVE_GETIFADDRS 1 and #define HAVE_IFADDRS_H 1 on unices but that does not work on AIX. Maybe it is easier to wait for the next c-ares release.

@richardlau

Copy link
Copy Markdown
Member

@nodejs/platform-aix can you help? I tried to work around c-ares/c-ares#668 by adding #define HAVE_GETIFADDRS 1 and #define HAVE_IFADDRS_H 1 on unices but that does not work on AIX. Maybe it is easier to wait for the next c-ares release.

AIX doesn't have ifaddrs.h so those defines should be 0 on AIX.

@lpinca

Copy link
Copy Markdown
Member

Yes, I understand, but I see no other way to work around the bug. I will remove the defines everywhere when the next c-ares release is cut.

@lpincalpinca added the blocked PRs that are blocked by other issues or PRs. label Dec 19, 2023
@richardlau

Copy link
Copy Markdown
Member

Yes, I understand, but I see no other way to work around the bug. I will remove the defines everywhere when the next c-ares release is cut.

I think it makes sense to have those defines on platforms that have ifaddrs.h, just not on those that do not (e.g. AIX).

@lpinca

lpinca commented Dec 19, 2023

Copy link
Copy Markdown
Member

Ok, but I'm not sure if it is supported on all solaris versions. I think we should remove them there too.

@richardlau

Copy link
Copy Markdown
Member

Ok, but I'm not sure if it is supported on all solaris versions. I think we should remove them there too.

Well we have a team to ask re. that -- ping @nodejs/platform-smartos.

@nodejs-github-botnodejs-github-bot changed the title deps: update c-ares to 1.24.0deps: update c-ares to 1.25.0Jan 5, 2024
@lpincalpinca closed this Jan 5, 2024
@lpinca
lpinca deleted the actions/tools-update-c-ares branch January 5, 2024 14:42
@lpinca

Copy link
Copy Markdown
Member

Closed in favor of #51385.

@lpincalpinca mentioned this pull request Jan 5, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blockedPRs that are blocked by other issues or PRs.caresIssues and PRs related to the c-ares dependency or the cares_wrap binding.dependenciesPull requests that update a dependency file.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nodejs-github-bot@lpinca@richardlau