Skip to content

fs: remove internalModuleReadJSON binding - #51224

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:remove-unused-type
Dec 21, 2023
Merged

fs: remove internalModuleReadJSON binding#51224
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:remove-unused-type

Conversation

@anonrig

@anonriganonrig commented Dec 19, 2023

Copy link
Copy Markdown
Member

This function got removed in one of the previous pull requests and we forgot it to remove it from typings.

Refs: 45e4f82912

@aduh95

Copy link
Copy Markdown
Contributor

This function got removed in one of the previous pull requests

Can you please add to the PR description a Refs: linking to the commit or PR that removed it?

@anonrig

Copy link
Copy Markdown
MemberAuthor

Can you please add to the PR description a Refs: linking to the commit or PR that removed it?

Definitely, updated the PR description.

@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 19, 2023
@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 20, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2023
@nodejs-github-bot
nodejs-github-bot merged commit bfa2eeb into nodejs:mainDec 21, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in bfa2eeb

RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
PR-URL: #51224
Refs: 45e4f82912
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jan 2, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51224
Refs: 45e4f82912
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.typings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@anonrig@aduh95@nodejs-github-bot@KhafraDev