Skip to content

timers: export timers.promises - #51246

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:feat/timers-export-promises
Dec 23, 2023
Merged

timers: export timers.promises#51246
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:feat/timers-export-promises

Conversation

@marco-ippolito

@marco-ippolitomarco-ippolito commented Dec 21, 2023•
edited by aduh95
Loading

Copy link
Copy Markdown
Member

export timers.promises

Fixes: #51237

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Dec 21, 2023
@marco-ippolito
marco-ippolitoforce-pushed the feat/timers-export-promises branch from 6209ba4 to b44967bCompareDecember 21, 2023 12:45
@richardlaurichardlau added the semver-minor PRs that contain new features and should be released in the next minor version. label Dec 21, 2023
@marco-ippolitomarco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56441/

@nodejs-github-bot

nodejs-github-bot commented Dec 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56442/

@nodejs-github-bot

nodejs-github-bot commented Dec 21, 2023•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56445/ 💚

@atlowChemiatlowChemi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 22, 2023
@marco-ippolitomarco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 22, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 23, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 6329d2c into nodejs:mainDec 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 23, 2023

Copy link
Copy Markdown
Collaborator

Landed in 6329d2c

RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@marco-ippolito@RafaelGSS
timers: export timers.promises
c31ed51
PR-URL: #51246Fixes: #51237
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@RafaelGSSRafaelGSS mentioned this pull request Jan 2, 2024
Merged
RafaelGSS added a commit that referenced this pull request Jan 2, 2024
@RafaelGSS
2024-01-04, Version 21.6.0 (Current)
5c87469
Notable changes:
doc:
* (SEMVER-MINOR) add documentation for --build-snapshot-config (Anna Henningsen) #50453
lib,src,permission:
* (SEMVER-MINOR) port path.resolve to C++ (Rafael Gonzaga) #50758
net:
* (SEMVER-MINOR) add connection attempt events (Paolo Insogna) #51045
src:
* (SEMVER-MINOR) support configurable snapshot (Joyee Cheung) #50453
src,permission:
* (SEMVER-MINOR) add --allow-addon flag (Rafael Gonzaga) #51183
timers:
* (SEMVER-MINOR) export timers.promises (Marco Ippolito) #51246
PR-URL: #51342
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
RafaelGSS added a commit to RafaelGSS/node that referenced this pull request Jan 3, 2024
@RafaelGSS
2024-01-04, Version 21.6.0 (Current)
52915b6
Notable changes:
doc:
* (SEMVER-MINOR) add documentation for --build-snapshot-config (Anna Henningsen) nodejs#50453
lib,src,permission:
* (SEMVER-MINOR) port path.resolve to C++ (Rafael Gonzaga) nodejs#50758
net:
* (SEMVER-MINOR) add connection attempt events (Paolo Insogna) nodejs#51045
src:
* (SEMVER-MINOR) support configurable snapshot (Joyee Cheung) nodejs#50453
src,permission:
* (SEMVER-MINOR) add --allow-addon flag (Rafael Gonzaga) nodejs#51183
timers:
* (SEMVER-MINOR) export timers.promises (Marco Ippolito) nodejs#51246
PR-URL: nodejs#51342
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
RafaelGSS added a commit that referenced this pull request Jan 5, 2024
@RafaelGSS
2024-01-09, Version 21.6.0 (Current)
f3105d3
Notable changes:
doc:
* (SEMVER-MINOR) add documentation for --build-snapshot-config (Anna Henningsen) #50453
lib,src,permission:
* (SEMVER-MINOR) port path.resolve to C++ (Rafael Gonzaga) #50758
net:
* (SEMVER-MINOR) add connection attempt events (Paolo Insogna) #51045
src:
* (SEMVER-MINOR) support configurable snapshot (Joyee Cheung) #50453
src,permission:
* (SEMVER-MINOR) add --allow-addon flag (Rafael Gonzaga) #51183
timers:
* (SEMVER-MINOR) export timers.promises (Marco Ippolito) #51246
PR-URL: #51342
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
RafaelGSS added a commit that referenced this pull request Jan 11, 2024
@RafaelGSS
2024-01-15, Version 21.6.0 (Current)
f38a9a5
Notable changes:
doc:
* (SEMVER-MINOR) add documentation for --build-snapshot-config (Anna Henningsen) #50453
lib,src,permission:
* (SEMVER-MINOR) port path.resolve to C++ (Rafael Gonzaga) #50758
net:
* (SEMVER-MINOR) add connection attempt events (Paolo Insogna) #51045
src:
* (SEMVER-MINOR) support configurable snapshot (Joyee Cheung) #50453
src,permission:
* (SEMVER-MINOR) add --allow-addon flag (Rafael Gonzaga) #51183
timers:
* (SEMVER-MINOR) export timers.promises (Marco Ippolito) #51246
PR-URL: #51342
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
RafaelGSS added a commit that referenced this pull request Jan 15, 2024
@RafaelGSS
2024-01-15, Version 21.6.0 (Current)
e133e51
Notable changes:
doc:
* (SEMVER-MINOR) add documentation for --build-snapshot-config (Anna Henningsen) #50453
lib,src,permission:
* (SEMVER-MINOR) port path.resolve to C++ (Rafael Gonzaga) #50758
net:
* (SEMVER-MINOR) add connection attempt events (Paolo Insogna) #51045
src:
* (SEMVER-MINOR) support configurable snapshot (Joyee Cheung) #50453
src,permission:
* (SEMVER-MINOR) add --allow-addon flag (Rafael Gonzaga) #51183
timers:
* (SEMVER-MINOR) export timers.promises (Marco Ippolito) #51246
PR-URL: #51342
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
@RafaelGSS@Medhansh404
2024-01-15, Version 21.6.0 (Current)
2958d92
Notable changes:
doc:
* (SEMVER-MINOR) add documentation for --build-snapshot-config (Anna Henningsen) nodejs#50453
lib,src,permission:
* (SEMVER-MINOR) port path.resolve to C++ (Rafael Gonzaga) nodejs#50758
net:
* (SEMVER-MINOR) add connection attempt events (Paolo Insogna) nodejs#51045
src:
* (SEMVER-MINOR) support configurable snapshot (Joyee Cheung) nodejs#50453
src,permission:
* (SEMVER-MINOR) add --allow-addon flag (Rafael Gonzaga) nodejs#51183
timers:
* (SEMVER-MINOR) export timers.promises (Marco Ippolito) nodejs#51246
PR-URL: nodejs#51342
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@marco-ippolito@richardlau
timers: export timers.promises
fe922f0
PR-URL: #51246Fixes: #51237
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@rluvatonrluvatonrluvaton approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes
+1 more reviewer
@apapirovskiapapirovskiapapirovski approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.semver-minorPRs that contain new features and should be released in the next minor version.timersIssues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

node:timers should also export promises as field like node:fs does

7 participants

@marco-ippolito@nodejs-github-bot@apapirovski@jasnell@rluvaton@atlowChemi@richardlau