Skip to content

src: eliminate duplicate code in histogram.cc - #51263

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jasnell:histogram-simplification
Dec 25, 2023
Merged

src: eliminate duplicate code in histogram.cc#51263
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jasnell:histogram-simplification

Conversation

@jasnell

@jasnelljasnell commented Dec 23, 2023

Copy link
Copy Markdown
Member

Could likely benefit from some fast-api implementations as well, but that can be done separately.

@jasnell
jasnell requested a review from anonrigDecember 23, 2023 02:48
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Dec 23, 2023
@jasnell
jasnell marked this pull request as draft December 23, 2023 02:49
@jasnell
jasnellforce-pushed the histogram-simplification branch from 050fa45 to 57fcfd2CompareDecember 23, 2023 03:11
@jasnell
jasnell marked this pull request as ready for review December 23, 2023 03:11
@jasnelljasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2023
@jasnell
jasnellforce-pushed the histogram-simplification branch from 57fcfd2 to 5fbcc74CompareDecember 23, 2023 03:15
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 23, 2023

Copy link
Copy Markdown
Collaborator

@jasnelljasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 23, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 25, 2023
@nodejs-github-bot
nodejs-github-bot merged commit a3a4eff into nodejs:mainDec 25, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in a3a4eff

RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
PR-URL: #51263
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jan 2, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51263
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jasnell@nodejs-github-bot@anonrig@marco-ippolito