Uh oh!
There was an error while loading. Please reload this page.
doc: added details about statfs.type and statfs.bsize - #51301
Closed
Jordan-Nguy wants to merge 1 commit into
Closed
Conversation
Jordan-Nguy
marked this pull request as draft
January 16, 2024 08:53
Jordan-Nguy
marked this pull request as ready for review
January 16, 2024 08:53
Jordan-Nguy
marked this pull request as draft
January 18, 2024 23:00
Jordan-Nguy
marked this pull request as ready for review
January 18, 2024 23:00
aduh95
commented
May 12, 2024
Contributor
/cc @nodejs/fs |
LiviaMedeiros
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution! The changes LGTM with the following nit.
The decimal part might be redundant: usually users can use hex values directly:
exportconstREISERFS_SUPER_MAGIC=0x52654973;// orconstmagic2humanReadable={ ...,0x52654973: 'ReiserFS', ... };// or evenif(statfsBigInt.type===0x52654973n){// reiserfsI would suggest adding a link to statfs(2) manpage instead of pasting the whole table here.
This way, we won't have to update the list every time a new fs emerges.
Uh oh!
There was an error while loading. Please reload this page.
LiviaMedeiros
approved these changes
May 16, 2024
Magic numbers from man page of statfs.
aduh95
reviewed
May 17, 2024
| * {number|bigint} | ||
| Type of file system. | ||
| Magic number of file system in decimal. |
Contributor
There was a problem hiding this comment.
It's not in decimal, it's just.. a number (if anything it's in binary, or IEEE 754).
Suggested change
| Magic number of file system in decimal. | |
| Magic number of file system. |
aduh95
reviewed
May 17, 2024
| | Filesystem Type | Hexadecimal | Decimal | | ||
| | ----------------------- | ------------ | ------------ | | ||
| | ADFS\_SUPER\_MAGIC | `0xadf5` | `44533` | |
Contributor
There was a problem hiding this comment.
nit: it would be more readable to wrap those in ticks
Suggested change
| |ADFS\_SUPER\_MAGIC|`0xadf5`|`44533`| | |
| |`ADFS_SUPER_MAGIC`|`0xadf5`|`44533`| |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added byte unit to
statfs.bsizedescription. Addedstatfs.typelist of potential values pulled from man page of statfs on Linux.Fixes: #50749