Uh oh!
There was an error while loading. Please reload this page.
watch: clarify that the fileName parameter can be null - #51305
Merged
Conversation
Add a comment to clarify that the `fileName` parameter can be `null` if the file name cannot be determined.
lpincaforce-pushed
the
add/link-to-comment
branch
from
December 28, 2023 21:21
fc3bdab to
660659fCompareH4ad
approved these changes
Dec 28, 2023
Uh oh!
There was an error while loading. Please reload this page.
anonrig
approved these changes
Dec 28, 2023
nodejs-github-bot
commented
Dec 29, 2023
Collaborator
benjamingr
approved these changes
Dec 29, 2023
nodejs-github-bot
commented
Dec 29, 2023
Collaborator
nodejs-github-bot
commented
Dec 29, 2023
Collaborator
nodejs-github-bot
commented
Dec 29, 2023
Collaborator
nodejs-github-bot
commented
Dec 30, 2023
Collaborator
Landed in 8bb3027 |
RafaelGSS pushed a commit
that referenced
this pull request
Jan 2, 2024
Add a comment to clarify that the `fileName` parameter can be `null` if the file name cannot be determined. PR-URL: #51305 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
richardlau pushed a commit
that referenced
this pull request
Mar 25, 2024
Add a comment to clarify that the `fileName` parameter can be `null` if the file name cannot be determined. PR-URL: #51305 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a comment to clarify that the
fileNameparameter can benullif the file name cannot be determined.Refs: #49891 (comment)