http2: Receive customsettings by martenrichter · Pull Request #51323 · nodejs/node

martenrichter · 2023-12-31T15:11:54Z

This commit gives node.js the ability to also receive custom settings, in addition to sending, them which was implemented before. The custom settings received are limited to setting ids, that were specified before, when creating the session eithers through the server or the client.

nodejs-github-bot · 2023-12-31T15:11:59Z

Review requested:

@nodejs/http
@nodejs/http2
@nodejs/net

martenrichter · 2023-12-31T15:13:00Z

Currently , the customSettings property is limited to unknown settings. One may also decide to report all settings there.

This commit gives node.js the ability to also receive custom settings, in addition to sending, them which was implemented before. The custom settings received are limited to setting ids, that were specified before, when creating the session eithers through the server or the client.

martenrichter · 2023-12-31T16:24:35Z

This PR is an extension to
#48962
and
#49025
which dealt with sending the settings. Upstream adviced me, where I can get the settings from:
nghttp2/nghttp2#1933

I am extending it since, for web transport over http/2, the initial flow control windows are also sent and received via settings. Understanding the flow control more, I assume there can be situations that will starve the flow control (or fail the connection on the capsule level) if the wrong initial settings are assumed.

nodejs-github-bot · 2023-12-31T17:40:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56610/

mcollina

lgtm

nodejs-github-bot · 2023-12-31T17:47:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56611/

nodejs-github-bot · 2024-01-01T18:05:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56619/

nodejs-github-bot · 2024-01-02T10:00:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56626/

nodejs-github-bot · 2024-01-02T10:00:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56625/

nodejs-github-bot · 2024-01-02T21:08:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56631/

nodejs-github-bot · 2024-01-03T09:08:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56645/

martenrichter · 2024-01-03T09:09:45Z

Do I have to do anything about the failing tests? If I look at the output, I do not have a clue, if anything is really failing....

nodejs-github-bot · 2024-01-03T11:10:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56648/

mcollina · 2024-01-03T22:06:24Z

@nodejs/build could you help with this one?

nodejs-github-bot · 2024-01-03T22:15:38Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56654/

ShogunPanda

LGTM!

nodejs-github-bot · 2024-01-07T17:33:54Z

Landed in bf37d4b

This commit gives node.js the ability to also receive custom settings, in addition to sending, them which was implemented before. The custom settings received are limited to setting ids, that were specified before, when creating the session eithers through the server or the client. PR-URL: nodejs#51323 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

This commit gives node.js the ability to also receive custom settings, in addition to sending, them which was implemented before. The custom settings received are limited to setting ids, that were specified before, when creating the session eithers through the server or the client. PR-URL: #51323 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

Notable changes: build: * (SEMVER-MINOR) build opt to set local location of headers (Michael Dawson) #51525 crypto: * (SEMVER-MINOR) implement crypto.hash() (Joyee Cheung) #51044 * update root certificates to NSS 3.98 (Node.js GitHub Bot) #51794 doc: * add zcbenz to collaborators (Cheng Zhao) #51812 * add lemire to collaborators (Daniel Lemire) #51572 http2: * (SEMVER-MINOR) add h2 compat support for appendHeader (Tim Perry) #51412 * (SEMVER-MINOR) add server handshake utility (snek) #51172 * (SEMVER-MINOR) receive customsettings (Marten Richter) #51323 lib: * (SEMVER-MINOR) move encodingsMap to internal/util (Joyee Cheung) #51044 sea: * (SEMVER-MINOR) support sea.getRawAsset() (Joyee Cheung) #50960 * (SEMVER-MINOR) support embedding assets (Joyee Cheung) #50960 src: * (SEMVER-MINOR) print string content better in BlobDeserializer (Joyee Cheung) #50960 * (SEMVER-MINOR) support multi-line values for .env file (IlyasShabi) #51289 * (SEMVER-MINOR) add `process.loadEnvFile` and `util.parseEnv` (Yagiz Nizipli) #51476 * (SEMVER-MINOR) do not coerce dotenv paths (Tobias Nießen) #51425 stream: * (SEMVER-MINOR) implement `min` option for `ReadableStreamBYOBReader.read` (Mattias Buelens) #50888 util: * (SEMVER-MINOR) add styleText API to text formatting (Rafael Gonzaga) #51850 vm: * (SEMVER-MINOR) support using the default loader to handle dynamic import() (Joyee Cheung) #51244 PR-URL: #51932

This commit gives node.js the ability to also receive custom settings, in addition to sending, them which was implemented before. The custom settings received are limited to setting ids, that were specified before, when creating the session eithers through the server or the client. PR-URL: #51323 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Dec 31, 2023

martenrichter force-pushed the recvaddlsettings branch 3 times, most recently from 835fdce to 42751d9Compare December 31, 2023 16:02

martenrichter force-pushed the recvaddlsettings branch from b9844c1 to b8616cdCompare December 31, 2023 16:12

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 31, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 31, 2023

mcollina approved these changes Dec 31, 2023
View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 31, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 31, 2023

mcollina added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 4, 2024

mcollina requested review from ShogunPanda and jasnell January 4, 2024 08:15

ShogunPanda approved these changes Jan 6, 2024
View reviewed changes

marco-ippolito approved these changes Jan 6, 2024
View reviewed changes

mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 7, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 7, 2024

nodejs-github-bot merged commit bf37d4b into nodejs:mainJan 7, 2024

targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Feb 15, 2024

marco-ippolito mentioned this pull request Mar 1, 2024
v21.7.0 proposal #51932
Merged

richardlau mentioned this pull request Mar 25, 2024
v20.12.0 proposal #52212
Merged

Uh oh!

Uh oh!

Conversation

martenrichter commented Dec 31, 2023

Uh oh!

nodejs-github-bot commented Dec 31, 2023

Uh oh!

martenrichter commented Dec 31, 2023

Uh oh!

martenrichter commented Dec 31, 2023

Uh oh!

nodejs-github-bot commented Dec 31, 2023

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Dec 31, 2023

Uh oh!

nodejs-github-bot commented Jan 1, 2024

Uh oh!

nodejs-github-bot commented Jan 2, 2024

Uh oh!

nodejs-github-bot commented Jan 2, 2024

Uh oh!

nodejs-github-bot commented Jan 2, 2024

Uh oh!

nodejs-github-bot commented Jan 3, 2024

Uh oh!

martenrichter commented Jan 3, 2024

Uh oh!

nodejs-github-bot commented Jan 3, 2024

Uh oh!

mcollina commented Jan 3, 2024

Uh oh!

nodejs-github-bot commented Jan 3, 2024

Uh oh!

ShogunPanda left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jan 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants