Skip to content

src: refactor GetCreationContext calls - #51367

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
pluris:fix/context_checked
Jan 7, 2024
Merged

src: refactor GetCreationContext calls#51367
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
pluris:fix/context_checked

Conversation

@pluris

@plurispluris commented Jan 4, 2024

Copy link
Copy Markdown
Contributor

Added missing changes.

Refs: #51287

@nodejs-github-bot

nodejs-github-bot commented Jan 4, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/vm

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jan 4, 2024
@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jan 7, 2024•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56701/ 💛

@jasnelljasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Jan 7, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 7, 2024
@nodejs-github-bot
nodejs-github-bot merged commit b25f2cd into nodejs:mainJan 7, 2024
@nodejs-github-bot

nodejs-github-bot commented Jan 7, 2024

Copy link
Copy Markdown
Collaborator

Landed in b25f2cd

marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Jan 12, 2024
Jungku Lee@marco-ippolito
src: refactor GetCreationContext calls
8d7bd70
PR-URL: nodejs#51367
Refs: nodejs#51287
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
Jungku Lee@Medhansh404
src: refactor GetCreationContext calls
46c3ac0
PR-URL: nodejs#51367
Refs: nodejs#51287
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Feb 15, 2024
Jungku Lee@targos
src: refactor GetCreationContext calls
b271cc5
PR-URL: #51367
Refs: #51287
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@marco-ippolitomarco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
Jungku Lee@richardlau
src: refactor GetCreationContext calls
50ec55c
PR-URL: #51367
Refs: #51287
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@anonriganonriganonrig approved these changes
@legendecaslegendecaslegendecas approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pluris@nodejs-github-bot@jasnell@lpinca@anonrig@legendecas