Skip to content

[v21.x] Revert "fs: remove workaround for esm package" - #51390

Closed
jeremymeng wants to merge 1 commit into
nodejs:v21.x-stagingfrom
jeremymeng:bring-back-workaround-for-esm
Closed

[v21.x] Revert "fs: remove workaround for esm package"#51390
jeremymeng wants to merge 1 commit into
nodejs:v21.x-stagingfrom
jeremymeng:bring-back-workaround-for-esm

Conversation

@jeremymeng

@jeremymengjeremymeng commented Jan 6, 2024•
edited
Loading

Copy link
Copy Markdown

Fixes: #51081

@nodejs-github-botnodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. v21.x labels Jan 6, 2024
@jeremymeng

jeremymeng commented Jan 6, 2024

Copy link
Copy Markdown
Author

per discussion at #51356 (comment), targeting v21.x-staging

H4ad
H4ad previously approved these changes Jan 10, 2024
View reviewed changes
@H4ad
H4ad dismissed their stale reviewJanuary 10, 2024 21:58

Before approving, do we have some docs about reverting changes? Should we actually revert or create a new commit with the change?

H4ad
H4ad approved these changes Jan 10, 2024
View reviewed changes

@H4adH4ad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to reverting commits docs, you only need to include Fixes: #PR in the PR message, can you update that?

@H4adH4ad added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 10, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2024
@nodejs-github-bot

nodejs-github-bot commented Jan 10, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56739/

@aduh95aduh95 changed the title Revert "fs: remove workaround for esm package"[v21.x] Revert "fs: remove workaround for esm package"Jan 10, 2024
@aduh95

aduh95 commented Jan 10, 2024

Copy link
Copy Markdown
Contributor

you only need to include Fixes: #PR in the PR message, can you update that?

No need to modify the commit message for that, you can edit the PR description and it will be picked up by ncu and added to the commit message upon landing. But not sure if we use the same process for landing PRs on staging branches.

RafaelGSS
RafaelGSS reviewed Jan 10, 2024
View reviewed changes

@RafaelGSSRafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why revert it only to v21.x but not main?

@jeremymeng

jeremymeng commented Jan 10, 2024

Copy link
Copy Markdown
Author

According to reverting commits docs, you only need to include Fixes: #PR in the PR message, can you update that?

Done

@targos

targos commented Feb 15, 2024

Copy link
Copy Markdown
Member

@RafaelGSS Because the esm package is archived and will never be fixed.

@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 15, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 15, 2024
@nodejs-github-bot

nodejs-github-bot commented Feb 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57099/

@targos
targosforce-pushed the bring-back-workaround-for-esm branch from 1c408b0 to a8d2d56CompareFebruary 20, 2024 07:56
@targos

targos commented Feb 20, 2024

Copy link
Copy Markdown
Member

Rebased to include jeremymeng@83f581d

@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2024
@nodejs-github-bot

nodejs-github-bot commented Feb 20, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57192/

@targostargos mentioned this pull request Feb 20, 2024
Closed
@nodejs-github-bot

nodejs-github-bot commented Feb 21, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57263/

@nodejs-github-bot

nodejs-github-bot commented Feb 21, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57264/

@nodejs-github-bot

nodejs-github-bot commented Feb 21, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57275/

@marco-ippolito

marco-ippolito commented Feb 26, 2024•
edited
Loading

Copy link
Copy Markdown
Member

@jeremymeng rebased

@marco-ippolito
marco-ippolitoforce-pushed the bring-back-workaround-for-esm branch from a8d2d56 to 3301a7dCompareFebruary 26, 2024 13:51
@jeremymeng@marco-ippolito
Revert "fs: remove workaround for esm package"
4368d29
This reverts commit 95b1989.
It appears that the workaround is still needed: issue nodejs#51081
@marco-ippolito
marco-ippolitoforce-pushed the bring-back-workaround-for-esm branch from 3301a7d to 4368d29CompareFebruary 27, 2024 11:21
@marco-ippolitomarco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 27, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 27, 2024
@nodejs-github-bot

nodejs-github-bot commented Feb 27, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57458/

@nodejs-github-bot

nodejs-github-bot commented Feb 27, 2024•
edited by marco-ippolito
Loading

Copy link
Copy Markdown
Collaborator

🟢 GREEN CI: https://ci.nodejs.org/job/node-test-pull-request/57460/

marco-ippolito pushed a commit that referenced this pull request Feb 27, 2024
@jeremymeng@marco-ippolito
Revert "fs: remove workaround for esm package"
5aacd62
This reverts commit 95b1989.
It appears that the workaround is still needed: issue #51081
Backport-PR-URL: #51390
PR-URL: #51390Fixes: #51081
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@H4adH4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 27, 2024
@marco-ippolitomarco-ippolito added backported-to-v21.x and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 27, 2024
marco-ippolito pushed a commit that referenced this pull request Feb 29, 2024
@jeremymeng@marco-ippolito
Revert "fs: remove workaround for esm package"
f130a33
This reverts commit 95b1989.
It appears that the workaround is still needed: issue #51081
Backport-PR-URL: #51390
PR-URL: #50907Fixes: #51081
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@ddribinddribin mentioned this pull request Feb 29, 2024
Closed
@marco-ippolito

marco-ippolito commented Mar 1, 2024

Copy link
Copy Markdown
Member

Landed in f130a33

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos approved these changes
@H4adH4adH4ad approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes
@mcollinamcollinaAwaiting requested review from mcollina
@aduh95aduh95Awaiting requested review from aduh95

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fsIssues and PRs related to the fs subsystem / file system.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jeremymeng@nodejs-github-bot@aduh95@targos@marco-ippolito@H4ad@RafaelGSS