Skip to content

test: fix flaky conditions for ppc64 SEA tests - #51422

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
richardlau:sea-ppc64
Jan 11, 2024
Merged

test: fix flaky conditions for ppc64 SEA tests#51422
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
richardlau:sea-ppc64

Conversation

@richardlau

@richardlaurichardlau commented Jan 10, 2024•
edited
Loading

Copy link
Copy Markdown
Member

In test status files, $system will be the OS and not the arch (which would be $arch).

Add missing single-executable-application test to the list of tests marked flaky on Linux ppc64le.

Refs: #50828
Refs: #50740

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 10, 2024
richardlau
richardlau commented Jan 10, 2024
View reviewed changes
Comment threadtest/sequential/sequential.status Outdated

@richardlaurichardlauJan 10, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re. $arch and the confusion in the previous PR's -- it looks like this should match process.arch:

node/tools/test.py

Lines 1676 to 1688 in e0b159e

archEngineContext=Execute([vm, "-p", "process.arch"], context)
vmArch=archEngineContext.stdout.rstrip()
ifarchEngineContext.exit_code!=0orvmArch=="undefined":
print("Can't determine the arch of: '%s'"%vm)
print(archEngineContext.stderr.rstrip())
continue
env= {
'mode': mode,
'system': utils.GuessOS(),
'arch': vmArch,
'type': get_env_type(vm, options.type, context),
'asan': get_asan_state(),
}

which on ppc64le is ppc64:

[iojs@test-osuosl-rhel8-ppc64--le-2 ~]$ ./build/workspace/node-test-commit-plinux/nodes/rhel8-ppc64le/out/Release/node -p process.archppc64[iojs@test-osuosl-rhel8-ppc64--le-2 ~]$

@richardlaurichardlau mentioned this pull request Jan 10, 2024
Merged
@richardlau
test: fix flaky conditions for ppc64 SEA tests
87dd223
In test status files, `$system` will be the OS and not the arch (which
would be `$arch`).
Add missing single-executable-application test to the list of tests
marked flaky on Linux ppc64le.
@RafaelGSSRafaelGSS added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 10, 2024
@github-actions

github-actionsBot commented Jan 10, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @RafaelGSS. Please 👍 to approve.

@richardlaurichardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 10, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@richardlau

richardlau commented Jan 10, 2024

Copy link
Copy Markdown
MemberAuthor

FWIW https://ci.nodejs.org/job/node-test-commit-plinux/51647/nodes=rhel8-ppc64le/ is a CI on a temporary branch that is the current v21.6.0-proposal branch with the commit for this PR cherry-picked on top. The six failing single-executable-application tests are marked flaky and the job is overall marked yellow/unstable (as opposed to red/failed).

mhdawson
mhdawson approved these changes Jan 10, 2024
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawsonmhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jan 10, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56734/

@nodejs-github-bot

nodejs-github-bot commented Jan 10, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56736/

@nodejs-github-bot

nodejs-github-bot commented Jan 10, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56738/

@richardlaurichardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 11, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 11, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 273c892 into nodejs:mainJan 11, 2024
@nodejs-github-bot

nodejs-github-bot commented Jan 11, 2024

Copy link
Copy Markdown
Collaborator

Landed in 273c892

@richardlau
richardlau deleted the sea-ppc64 branch January 11, 2024 12:33
RafaelGSS pushed a commit that referenced this pull request Jan 11, 2024
@richardlau@RafaelGSS
test: fix flaky conditions for ppc64 SEA tests
757a84c
In test status files, `$system` will be the OS and not the arch (which
would be `$arch`).
Add missing single-executable-application test to the list of tests
marked flaky on Linux ppc64le.
PR-URL: #51422
Refs: #50828
Refs: #50740
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Jan 12, 2024
@richardlau@marco-ippolito
test: fix flaky conditions for ppc64 SEA tests
25aaf1a
In test status files, `$system` will be the OS and not the arch (which
would be `$arch`).
Add missing single-executable-application test to the list of tests
marked flaky on Linux ppc64le.
PR-URL: nodejs#51422
Refs: nodejs#50828
Refs: nodejs#50740
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
@richardlau@Medhansh404
test: fix flaky conditions for ppc64 SEA tests
396dd89
In test status files, `$system` will be the OS and not the arch (which
would be `$arch`).
Add missing single-executable-application test to the list of tests
marked flaky on Linux ppc64le.
PR-URL: nodejs#51422
Refs: nodejs#50828
Refs: nodejs#50740
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau added a commit that referenced this pull request Mar 25, 2024
@richardlau
test: fix flaky conditions for ppc64 SEA tests
6ee5f50
In test status files, `$system` will be the OS and not the arch (which
would be `$arch`).
Add missing single-executable-application test to the list of tests
marked flaky on Linux ppc64le.
PR-URL: #51422
Refs: #50828
Refs: #50740
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@anonriganonriganonrig approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@richardlau@nodejs-github-bot@lpinca@anonrig@joyeecheung@mhdawson@RafaelGSS