Skip to content

doc: fix dns.lookup and dnsPromises.lookup description - #51517

Merged
aduh95 merged 10 commits into
nodejs:mainfrom
duncanchiu409:my-branch
Jan 30, 2024
Merged

doc: fix dns.lookup and dnsPromises.lookup description#51517
aduh95 merged 10 commits into
nodejs:mainfrom
duncanchiu409:my-branch

Conversation

@duncanchiu409

@duncanchiu409duncanchiu409 commented Jan 18, 2024

Copy link
Copy Markdown
Contributor

Fixes: #51482
Continue on: #51483

@nodejs-github-bot

nodejs-github-bot commented Jan 18, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-botnodejs-github-bot added dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations. labels Jan 18, 2024
ShogunPanda
ShogunPanda requested changes Jan 19, 2024
View reviewed changes
Comment threaddoc/api/dns.md Outdated
Comment threaddoc/api/dns.md Outdated
Comment threaddoc/api/dns.md Outdated
duncanchiu409and others added 3 commits January 26, 2024 14:18
@duncanchiu409@ShogunPanda
Update doc/api/dns.md
fa94817
Co-authored-by: Paolo Insogna <paolo@cowtech.it>
@duncanchiu409@ShogunPanda
Update doc/api/dns.md
6c1e119
Co-authored-by: Paolo Insogna <paolo@cowtech.it>
@duncanchiu409@ShogunPanda
Update doc/api/dns.md
03da199
Co-authored-by: Paolo Insogna <paolo@cowtech.it>
ShogunPanda
ShogunPanda requested changes Jan 26, 2024
View reviewed changes

@ShogunPandaShogunPanda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things are pointed out in #51517 (comment).
After that, it LGTM!

Comment threaddoc/api/dns.md Outdated
Comment threaddoc/api/dns.md Outdated
mcollina
mcollina approved these changes Jan 26, 2024
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

duncanchiu409and others added 2 commits January 27, 2024 15:28
@duncanchiu409@ShogunPanda
Update doc/api/dns.md
78af021
Co-authored-by: Paolo Insogna <paolo@cowtech.it>
@duncanchiu409@ShogunPanda
Update doc/api/dns.md
a1951a5
Co-authored-by: Paolo Insogna <paolo@cowtech.it>
lpinca
lpinca reviewed Jan 27, 2024
View reviewed changes
Comment threaddoc/api/dns.md Outdated
@duncanchiu409@lpinca
Update dns.md
6eeae0f
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
@aduh95

aduh95 commented Jan 29, 2024

Copy link
Copy Markdown
Contributor

Linter is failing

@duncanchiu409

duncanchiu409 commented Jan 29, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Is there something similar to lint --fix ? Is it make format-md?

aduh95
aduh95 previously approved these changes Jan 30, 2024
View reviewed changes
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 30, 2024
@aduh95
aduh95 dismissed their stale reviewJanuary 30, 2024 01:18

Wrong button

@aduh95
aduh95 merged commit 0f461aa into nodejs:mainJan 30, 2024
@aduh95

aduh95 commented Jan 30, 2024

Copy link
Copy Markdown
Contributor

Landed in 0f461aa

@duncanchiu409

duncanchiu409 commented Jan 30, 2024

Copy link
Copy Markdown
ContributorAuthor

Thanks to all for the work & take attention to my PR.

@domdomegg

domdomegg commented Feb 3, 2024

Copy link
Copy Markdown
Contributor

This isn't correct, as dicussed in #51482 and #51483 (comment)

We either need to make sure node actually has this behaviour, or revert this docs commit as this is taking it from ambigious to wrong :/

@domdomeggdomdomegg mentioned this pull request Feb 3, 2024
Merged
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Feb 9, 2024
@duncanchiu409@rdw-msft
doc: fix dns.lookup and dnsPromises.lookup description
126a6c3
PR-URL: nodejs#51517Fixes: nodejs#51482
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Feb 15, 2024
@duncanchiu409@targos
doc: fix dns.lookup and dnsPromises.lookup description
8c0a257
PR-URL: #51517Fixes: #51482
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@marco-ippolitomarco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@duncanchiu409@richardlau
doc: fix dns.lookup and dnsPromises.lookup description
1dae187
PR-URL: #51517Fixes: #51482
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca left review comments
@mcollinamcollinamcollina approved these changes
@ShogunPandaShogunPandaShogunPanda approved these changes
@aduh95aduh95aduh95 left review comments

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.dnsIssues and PRs related to the dns subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docs: dns docs for family = 0 and all = true is potentially misleading

7 participants

@duncanchiu409@nodejs-github-bot@aduh95@domdomegg@mcollina@ShogunPanda@lpinca