Skip to content

benchmark: fix api restriction for the permission category - #51528

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
bekcpear:benchmark-permission-fix
May 18, 2024
Merged

benchmark: fix api restriction for the permission category#51528
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
bekcpear:benchmark-permission-fix

Conversation

@bekcpear

Copy link
Copy Markdown
Contributor

give appropriate permissions to the following scripts:

  • permission-processhas-fs-read.js: 'ChildProcess' permission
  • permission-startup.js: 'FileSystemRead' permission

    Paths delimited by comma (,) are no longer allowed.

Refs: https://github.com/nodejs/node/blob/main/doc/api/cli.md#--allow-fs-read

@nodejs-github-botnodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. permission Issues and PRs related to the Permission Model labels Jan 19, 2024
@bekcpear
bekcpearforce-pushed the benchmark-permission-fix branch from 6331544 to b825e37CompareJanuary 19, 2024 19:07
@bekcpear

Copy link
Copy Markdown
ContributorAuthor

@bekcpear
bekcpear requested a review from lpincaJanuary 19, 2024 19:10
@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

give appropriate permissions to the following scripts:
* permission-processhas-fs-read.js: 'ChildProcess' permission
* permission-startup.js: 'FileSystemRead' permission
> Paths delimited by comma (,) are no longer allowed.
Refs: https://github.com/nodejs/node/blob/main/doc/api/cli.md#--allow-fs-read
Signed-off-by: Ryan Qian <i@bitbili.net>
@aduh95
aduh95force-pushed the benchmark-permission-fix branch from b825e37 to 111380eCompareMay 11, 2024 15:07
Comment threadbenchmark/permission/permission-startup.js Outdated
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 11, 2024
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 18, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 18, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/51528
✔ Done loading data for nodejs/node/pull/51528
----------------------------------- PR info ------------------------------------
Title benchmark: fix api restriction for the permission category (#51528)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch bekcpear:benchmark-permission-fix -> nodejs:main
Labels benchmark, author ready, permission
Commits 2
- benchmark: fix api restriction for the permission category
- Update benchmark/permission/permission-startup.js
Committers 2
- Antoine du Hamel - GitHub PR-URL: https://github.com/nodejs/node/pull/51528
Refs: https://github.com/nodejs/node/blob/main/doc/api/cli.md#--allow-fs-read
Reviewed-By: Luigi Pinca Reviewed-By: James M Snell Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51528
Refs: https://github.com/nodejs/node/blob/main/doc/api/cli.md#--allow-fs-read
Reviewed-By: Luigi Pinca Reviewed-By: James M Snell Reviewed-By: Antoine du Hamel --------------------------------------------------------------------------------
ℹ This PR was created on Fri, 19 Jan 2024 15:27:32 GMT
✔ Approvals: 3
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51528#pullrequestreview-1833462899
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/51528#pullrequestreview-1956583886
✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/51528#pullrequestreview-2064693399
✔ Last GitHub CI successful
ℹ Green GitHub CI is sufficient
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 51528
From https://github.com/nodejs/node
* branch refs/pull/51528/merge -> FETCH_HEAD
✔ Fetched commits as eaa839ed8ab4..be98c2b0b23c
--------------------------------------------------------------------------------
[main 707170ed86] benchmark: fix api restriction for the permission category
Author: Ryan Qian Date: Fri Jan 19 22:51:18 2024 +0800
2 files changed, 6 insertions(+), 3 deletions(-)
[main d07dad029f] Update benchmark/permission/permission-startup.js
Author: Antoine du Hamel Date: Thu May 16 21:19:29 2024 +0200
1 file changed, 2 insertions(+), 4 deletions(-)
✔ Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes
⚠ Found Refs: https://github.com/nodejs/node/blob/main/doc/api/cli.md#--allow-fs-read, skipping..
--------------------------------- New Message ----------------------------------
benchmark: fix api restriction for the permission category

give appropriate permissions to the following scripts:

  • permission-processhas-fs-read.js: 'ChildProcess' permission
  • permission-startup.js: 'FileSystemRead' permission

    Paths delimited by comma (,) are no longer allowed.

Refs: https://github.com/nodejs/node/blob/main/doc/api/cli.md#--allow-fs-read
Signed-off-by: Ryan Qian i@bitbili.net
PR-URL: #51528
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com

[detached HEAD 33758aeb4b] benchmark: fix api restriction for the permission category
Author: Ryan Qian i@bitbili.net
Date: Fri Jan 19 22:51:18 2024 +0800
2 files changed, 6 insertions(+), 3 deletions(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update benchmark/permission/permission-startup.js

PR-URL: #51528
Refs: https://github.com/nodejs/node/blob/main/doc/api/cli.md#--allow-fs-read
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com

[detached HEAD d85d69b123] Update benchmark/permission/permission-startup.js
Author: Antoine du Hamel duhamelantoine1995@gmail.com
Date: Thu May 16 21:19:29 2024 +0200
1 file changed, 2 insertions(+), 4 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/9139117635

@nodejs-github-botnodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label May 18, 2024
@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 18, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 18, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 8216cc9 into nodejs:mainMay 18, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 8216cc9

@bekcpear
bekcpear deleted the benchmark-permission-fix branch May 19, 2024 08:34
targos pushed a commit that referenced this pull request May 21, 2024
give appropriate permissions to the following scripts:
* permission-processhas-fs-read.js: 'ChildProcess' permission
* permission-startup.js: 'FileSystemRead' permission
> Paths delimited by comma (,) are no longer allowed.
Refs: https://github.com/nodejs/node/blob/main/doc/api/cli.md#--allow-fs-read
Signed-off-by: Ryan Qian <i@bitbili.net>
PR-URL: #51528
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jun 7, 2024
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
give appropriate permissions to the following scripts:
* permission-processhas-fs-read.js: 'ChildProcess' permission
* permission-startup.js: 'FileSystemRead' permission
> Paths delimited by comma (,) are no longer allowed.
Refs: https://github.com/nodejs/node/blob/main/doc/api/cli.md#--allow-fs-read
Signed-off-by: Ryan Qian <i@bitbili.net>
PR-URL: nodejs#51528
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
give appropriate permissions to the following scripts:
* permission-processhas-fs-read.js: 'ChildProcess' permission
* permission-startup.js: 'FileSystemRead' permission
> Paths delimited by comma (,) are no longer allowed.
Refs: https://github.com/nodejs/node/blob/main/doc/api/cli.md#--allow-fs-read
Signed-off-by: Ryan Qian <i@bitbili.net>
PR-URL: #51528
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@marco-ippolitomarco-ippolito mentioned this pull request Jul 19, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.benchmarkIssues and PRs related to the benchmark subsystem.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.permissionIssues and PRs related to the Permission Model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@bekcpear@nodejs-github-bot@jasnell@lpinca@aduh95