Uh oh!
There was an error while loading. Please reload this page.
v21.6.1 proposal - #51530
Merged
Merged
Conversation
This reverts commit 4d3923a. PR-URL: #51491 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #51491 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RafaelGSS added a commit
that referenced
this pull request
Jan 19, 2024
Notable changes: This release fixes a bug in `undici` using WebStreams PR-URL: #51530
RafaelGSSforce-pushed
the
v21.6.1-proposal
branch
from
January 19, 2024 19:11
254b8cd to
7f9a864CompareMemberAuthor
anonrig
requested changes
Jan 19, 2024
Uh oh!
There was an error while loading. Please reload this page.
Notable changes: This release fixes a bug in `undici` using WebStreams PR-URL: #51530
RafaelGSSforce-pushed
the
v21.6.1-proposal
branch
from
January 20, 2024 13:02
7f9a864 to
3dc0e49CompareRafaelGSS
commented
Jan 21, 2024
MemberAuthor
@anonrig can you dismiss the review? |
anonrig
approved these changes
Jan 21, 2024
RafaelGSS
commented
Jan 22, 2024
MemberAuthor
FWIW Release is blocked because we are facing a problem with macOS binaries. |
RafaelGSS added a commit
that referenced
this pull request
Jan 22, 2024
Notable changes: This release fixes a bug in `undici` using WebStreams PR-URL: #51530
RafaelGSS added a commit
to RafaelGSS/nodejs.org
that referenced
this pull request
Jan 22, 2024
github-merge-queueBot
pushed a commit
to nodejs/nodejs.org
that referenced
this pull request
Jan 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2024-01-22, Version 21.6.1 (Current), @RafaelGSS
Notable Changes
This release fixes a bug in
undiciusing WebStreamsCommits
662ac95729] - Revert "stream: fix cloned webstreams not being unref'd" (Matteo Collina) #514911b8bba8aee] - test: add regression test for 51586 (Matteo Collina) #51491