Skip to content

src: preload function for Environment - #51539

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
zcbenz:feat-preload-env
Mar 4, 2024
Merged

src: preload function for Environment#51539
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
zcbenz:feat-preload-env

Conversation

@zcbenz

@zcbenzzcbenz commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

This PR provides an API in node::Environment to allow embedders to set a preload function for environment, which will run after the environment is loaded and before the main script runs.

This is similiar to the --require CLI option, but runs a C++ function, and can only be set by embedders.

The preload function can be used by embedders to inject scripts before running the main script, for example:

  1. In Electron it is used to initialize the ASAR virtual filesystem, inject custom process properties, etc.
  2. In VS Code it can be used to reset the module search paths for extensions.

/cc @nodejs/embedders @bpasero

@nodejs-github-bot

nodejs-github-bot commented Jan 22, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 22, 2024
@zcbenzzcbenz changed the title feat: preload function for Environmentsrc: preload function for EnvironmentJan 22, 2024
joyeecheung
joyeecheung reviewed Jan 22, 2024
View reviewed changes
Comment threadsrc/env.h Outdated
@zcbenz
zcbenzforce-pushed the feat-preload-env branch 2 times, most recently from 84d5f00 to c319459CompareJanuary 23, 2024 03:36
@zcbenzzcbenz mentioned this pull request Jan 23, 2024
Merged
5 tasks
anonrig
anonrig reviewed Jan 24, 2024
View reviewed changes
Comment threadsrc/node_snapshotable.cc Outdated
@zcbenz
zcbenzforce-pushed the feat-preload-env branch 4 times, most recently from 5e65ac6 to 289d86fCompareJanuary 30, 2024 12:19
@zcbenzzcbenz mentioned this pull request Jan 30, 2024
Closed
5 tasks
@zcbenzzcbenz added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2024
@nodejs-github-bot

nodejs-github-bot commented Feb 23, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57323/

joyeecheung
joyeecheung reviewed Feb 23, 2024
View reviewed changes
Comment threadsrc/node.h Outdated
@zcbenz
src: preload function for Environment
bc1e621
This PR adds a |preload| arg to the node::LoadEnvironment to allow
embedders to set a preload function for the environment, which will run
after the environment is loaded and before the main script runs.
This is similiar to the --require CLI option, but runs a C++ function,
and can only be set by embedders.
The preload function can be used by embedders to inject scripts before
running the main script, for example:
1. In Electron it is used to initialize the ASAR virtual filesystem,
inject custom process properties, etc.
2. In VS Code it can be used to reset the module search paths for
extensions.
@zcbenzzcbenz added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 26, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 26, 2024
@nodejs-github-bot

nodejs-github-bot commented Feb 26, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57422/

joyeecheung
joyeecheung approved these changes Feb 29, 2024
View reviewed changes

@joyeecheungjoyeecheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nit

Comment threadsrc/node.h Outdated
@zcbenz@joyeecheung
fixup! update comment
1a7ee83
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
@zcbenzzcbenz added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 3, 2024
@nodejs-github-bot

nodejs-github-bot commented Mar 4, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57577/

@zcbenzzcbenz added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 4, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 4, 2024
@nodejs-github-bot
nodejs-github-bot merged commit b34512e into nodejs:mainMar 4, 2024
@nodejs-github-bot

nodejs-github-bot commented Mar 4, 2024

Copy link
Copy Markdown
Collaborator

Landed in b34512e

@zcbenz
zcbenz deleted the feat-preload-env branch March 4, 2024 05:59
@zcbenzzcbenz mentioned this pull request Mar 4, 2024
Merged
@targostargos added the semver-minor PRs that contain new features and should be released in the next minor version. label Mar 7, 2024
@RafaelGSSRafaelGSS mentioned this pull request Apr 15, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@zcbenz@marco-ippolito
src: preload function for Environment
b3a11b5
This PR adds a |preload| arg to the node::LoadEnvironment to allow
embedders to set a preload function for the environment, which will run
after the environment is loaded and before the main script runs.
This is similiar to the --require CLI option, but runs a C++ function,
and can only be set by embedders.
The preload function can be used by embedders to inject scripts before
running the main script, for example:
1. In Electron it is used to initialize the ASAR virtual filesystem,
inject custom process properties, etc.
2. In VS Code it can be used to reset the module search paths for
extensions.
PR-URL: #51539
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
@marco-ippolitomarco-ippolito mentioned this pull request May 2, 2024
Merged
marco-ippolito added a commit that referenced this pull request May 2, 2024
@marco-ippolito
2024-05-07, Version 20.13.0 'Iron' (LTS)
2e68800
Notable changes:
benchmark:
* add AbortSignal.abort benchmarks (Raz Luvaton) #52408
buffer:
* improve `base64` and `base64url` performance (Yagiz Nizipli) #52428
crypto:
* deprecate implicitly shortened GCM tags (Tobias Nießen) #52345
deps:
* (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) #52138
* (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) #51462
* (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) #51278
dns:
* (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) #52492
doc:
* update release gpg keyserver (marco-ippolito) #52257
* add release key for marco-ippolito (marco-ippolito) #52257
* add UlisesGascon as a collaborator (Ulises Gascón) #51991
* (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) #51879
events,doc:
* mark CustomEvent as stable (Daeyeon Jeong) #52618
fs:
* add stacktrace to fs/promises (翠 / green) #49849
lib, url:
* (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) #52509
net:
* (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) #52474
report:
* (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) #51645
src:
* (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) #52595
* (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) #51977
* (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) #52023
* (SEMVER-MINOR) preload function for Environment (Cheng Zhao) #51539
stream:
* (SEMVER-MINOR) support typed arrays (IlyasShabi) #51866
test_runner:
* (SEMVER-MINOR) add suite() (Colin Ihrig) #52127
* (SEMVER-MINOR) support forced exit (Colin Ihrig) #52038
* (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) #51909
util:
* (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) #52040
v8:
* (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) #51927
watch:
* mark as stable (Moshe Atlow) #52074
PR-URL: #52793
marco-ippolito added a commit that referenced this pull request May 3, 2024
@marco-ippolito
2024-05-07, Version 20.13.0 'Iron' (LTS)
1766b1d
Notable changes:
benchmark:
* add AbortSignal.abort benchmarks (Raz Luvaton) #52408
buffer:
* improve `base64` and `base64url` performance (Yagiz Nizipli) #52428
crypto:
* deprecate implicitly shortened GCM tags (Tobias Nießen) #52345
deps:
* (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) #52138
* (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) #51462
* (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) #51278
dns:
* (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) #52492
doc:
* update release gpg keyserver (marco-ippolito) #52257
* add release key for marco-ippolito (marco-ippolito) #52257
* add UlisesGascon as a collaborator (Ulises Gascón) #51991
* (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) #51879
events,doc:
* mark CustomEvent as stable (Daeyeon Jeong) #52618
fs:
* add stacktrace to fs/promises (翠 / green) #49849
lib, url:
* (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) #52509
net:
* (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) #52474
report:
* (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) #51645
src:
* (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) #52595
* (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) #51977
* (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) #52023
* (SEMVER-MINOR) preload function for Environment (Cheng Zhao) #51539
stream:
* (SEMVER-MINOR) support typed arrays (IlyasShabi) #51866
test_runner:
* (SEMVER-MINOR) add suite() (Colin Ihrig) #52127
* (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) #51909
util:
* (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) #52040
v8:
* (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) #51927
watch:
* mark as stable (Moshe Atlow) #52074
PR-URL: #52793
marco-ippolito added a commit that referenced this pull request May 7, 2024
@marco-ippolito
2024-05-07, Version 20.13.0 'Iron' (LTS)
0d0efa4
Notable changes:
benchmark:
* add AbortSignal.abort benchmarks (Raz Luvaton) #52408
buffer:
* improve `base64` and `base64url` performance (Yagiz Nizipli) #52428
crypto:
* deprecate implicitly shortened GCM tags (Tobias Nießen) #52345
deps:
* (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) #52138
* (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) #51462
* (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) #51278
dns:
* (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) #52492
doc:
* update release gpg keyserver (marco-ippolito) #52257
* add release key for marco-ippolito (marco-ippolito) #52257
* add UlisesGascon as a collaborator (Ulises Gascón) #51991
* (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) #51879
events,doc:
* mark CustomEvent as stable (Daeyeon Jeong) #52618
fs:
* add stacktrace to fs/promises (翠 / green) #49849
lib, url:
* (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) #52509
net:
* (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) #52474
report:
* (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) #51645
src:
* (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) #52595
* (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) #51977
* (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) #52023
* (SEMVER-MINOR) preload function for Environment (Cheng Zhao) #51539
stream:
* (SEMVER-MINOR) support typed arrays (IlyasShabi) #51866
test_runner:
* (SEMVER-MINOR) add suite() (Colin Ihrig) #52127
* (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) #51909
util:
* (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) #52040
v8:
* (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) #51927
watch:
* mark as stable (Moshe Atlow) #52074
PR-URL: #52793
marco-ippolito added a commit that referenced this pull request May 7, 2024
@marco-ippolito
2024-05-07, Version 20.13.0 'Iron' (LTS)
9a1df15
Notable changes:
benchmark:
* add AbortSignal.abort benchmarks (Raz Luvaton) #52408
buffer:
* improve `base64` and `base64url` performance (Yagiz Nizipli) #52428
crypto:
* deprecate implicitly shortened GCM tags (Tobias Nießen) #52345
deps:
* (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) #52138
* (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) #51462
* (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) #51278
dns:
* (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) #52492
doc:
* update release gpg keyserver (marco-ippolito) #52257
* add release key for marco-ippolito (marco-ippolito) #52257
* add UlisesGascon as a collaborator (Ulises Gascón) #51991
* (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) #51879
events,doc:
* mark CustomEvent as stable (Daeyeon Jeong) #52618
fs:
* add stacktrace to fs/promises (翠 / green) #49849
lib, url:
* (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) #52509
net:
* (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) #52474
report:
* (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) #51645
src:
* (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) #52595
* (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) #51977
* (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) #52023
* (SEMVER-MINOR) preload function for Environment (Cheng Zhao) #51539
stream:
* (SEMVER-MINOR) support typed arrays (IlyasShabi) #51866
test_runner:
* (SEMVER-MINOR) add suite() (Colin Ihrig) #52127
* (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) #51909
util:
* (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) #52040
v8:
* (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) #51927
watch:
* mark as stable (Moshe Atlow) #52074
PR-URL: #52793
codebytere added a commit to electron/electron that referenced this pull request May 8, 2024
@codebytere
src: preload function for Environment
cab549f
nodejs/node#51539
jkleinsc pushed a commit to electron/electron that referenced this pull request May 13, 2024
@electron-roller@codebytere@patchup
chore: bump node to v20.13.1 (main) (#42088)
653d0f0
* chore: bump node in DEPS to v20.13.0
* crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL
nodejs/node#52217
* test: skip test for dynamically linked OpenSSL
nodejs/node#52542
* lib, url: add a `windows` option to path parsing
nodejs/node#52509
* src: use dedicated routine to compile function for builtin CJS loader
nodejs/node#52016
* test: mark test as flaky
nodejs/node#52671
* build,tools: add test-ubsan ci
nodejs/node#46297
* src: preload function for Environment
nodejs/node#51539
* chore: fixup patch indices
* deps: update c-ares to 1.28.1
nodejs/node#52285
* chore: handle updated filenames
- nodejs/node#51999
- nodejs/node#51927
* chore: bump node in DEPS to v20.13.1
* events: extract addAbortListener for safe internal use
nodejs/node#52081
* module: print location of unsettled top-level await in entry points
nodejs/node#51999
* fs: add stacktrace to fs/promises
nodejs/node#49849
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
codebytere added a commit to electron/electron that referenced this pull request May 31, 2024
@codebytere
src: preload function for Environment
040b00d
nodejs/node#51539
codebytere added a commit to electron/electron that referenced this pull request May 31, 2024
@codebytere
src: preload function for Environment
ccb0a72
nodejs/node#51539
codebytere added a commit to electron/electron that referenced this pull request May 31, 2024
@electron-roller@codebytere
chore: bump node to v20.14.0 (31-x-y) (#42295)
9a87938
* chore: bump node in DEPS to v20.13.1
* chore: bump node in DEPS to v20.14.0
* crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL
nodejs/node#52217
* test: skip test for dynamically linked OpenSSL
nodejs/node#52542
* lib, url: add a `windows` option to path parsing
nodejs/node#52509
* src: use dedicated routine to compile function for builtin CJS loader
nodejs/node#52016
* test: mark test as flaky
nodejs/node#52671
* build,tools: add test-ubsan ci
nodejs/node#46297
* src: preload function for Environment
nodejs/node#51539
* chore: fixup patch indices
* deps: update c-ares to 1.28.1
nodejs/node#52285
* chore: handle updated filenames
* events: extract addAbortListener for safe internal use
nodejs/node#52081
* module: print location of unsettled top-level await in entry points
nodejs/node#51999
* fs: add stacktrace to fs/promises
nodejs/node#49849
* chore: fixup patch indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
codebytere added a commit to electron/electron that referenced this pull request Jun 1, 2024
@electron-roller@zcbenz
@codebytere@patchup
chore: bump node to v20.14.0 (30-x-y) (#42294)
3be3381
* chore: bump node in DEPS to v20.13.1
* chore: bump node in DEPS to v20.14.0
* chore: update build_add_gn_build_files.patch
* chore: update patches
* chore: update patches
* build: encode non-ASCII Latin1 characters as one byte in JS2C
nodejs/node#51605
* crypto: use EVP_MD_fetch and cache EVP_MD for hashes
nodejs/node#51034
* chore: update filenames.json
* chore: update patches
* src: support configurable snapshot
nodejs/node#50453
* test: remove test-domain-error-types flaky designation
nodejs/node#51717
* src: avoid draining platform tasks at FreeEnvironment
nodejs/node#51290
* chore: fix accidentally deleted v8 dep
* lib: define FormData and fetch etc. in the built-in snapshot
nodejs/node#51598
* chore: remove stray log
* crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL
nodejs/node#52217
* test: skip test for dynamically linked OpenSSL
nodejs/node#52542
* lib, url: add a `windows` option to path parsing
nodejs/node#52509
* src: use dedicated routine to compile function for builtin CJS loader
nodejs/node#52016
* test: mark test as flaky
nodejs/node#52671
* build,tools: add test-ubsan ci
nodejs/node#46297
* src: preload function for Environment
nodejs/node#51539
* deps: update c-ares to 1.28.1
nodejs/node#52285
* chore: fixup
* events: extract addAbortListener for safe internal use
nodejs/node#52081
* module: print location of unsettled top-level await in entry points
nodejs/node#51999
* fs: add stacktrace to fs/promises
nodejs/node#49849
* chore: fixup indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Cheng <zcbenz@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@marco-ippolito@eliphazbouye
2024-05-07, Version 20.13.0 'Iron' (LTS)
66ad117
Notable changes:
benchmark:
* add AbortSignal.abort benchmarks (Raz Luvaton) nodejs#52408
buffer:
* improve `base64` and `base64url` performance (Yagiz Nizipli) nodejs#52428
crypto:
* deprecate implicitly shortened GCM tags (Tobias Nießen) nodejs#52345
deps:
* (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) nodejs#52138
* (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) nodejs#51462
* (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) nodejs#51278
dns:
* (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) nodejs#52492
doc:
* update release gpg keyserver (marco-ippolito) nodejs#52257
* add release key for marco-ippolito (marco-ippolito) nodejs#52257
* add UlisesGascon as a collaborator (Ulises Gascón) nodejs#51991
* (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) nodejs#51879
events,doc:
* mark CustomEvent as stable (Daeyeon Jeong) nodejs#52618
fs:
* add stacktrace to fs/promises (翠 / green) nodejs#49849
lib, url:
* (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) nodejs#52509
net:
* (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) nodejs#52474
report:
* (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) nodejs#51645
src:
* (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) nodejs#52595
* (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) nodejs#51977
* (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) nodejs#52023
* (SEMVER-MINOR) preload function for Environment (Cheng Zhao) nodejs#51539
stream:
* (SEMVER-MINOR) support typed arrays (IlyasShabi) nodejs#51866
test_runner:
* (SEMVER-MINOR) add suite() (Colin Ihrig) nodejs#52127
* (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) nodejs#51909
util:
* (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) nodejs#52040
v8:
* (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) nodejs#51927
watch:
* mark as stable (Moshe Atlow) nodejs#52074
PR-URL: nodejs#52793
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zcbenz@nodejs-github-bot@anonrig@joyeecheung@targos