Uh oh!
There was an error while loading. Please reload this page.
readable: Update docs for a case with a binary safe string reading - #5155
Closed
TriAnMan wants to merge 1 commit into
Closed
readable: Update docs for a case with a binary safe string reading#5155TriAnMan wants to merge 1 commit into
TriAnMan wants to merge 1 commit into
Conversation
Member
There was a problem hiding this comment.
I would flip these last two sentences around, or move the new sentence to a separate paragraph.
jasnell
commented
Feb 10, 2016
Member
LGTM with a nit. |
TriAnManforce-pushed
the
doc-readable-encoding-fix
branch
from
February 26, 2016 16:03
d184b48 to
eb748a2CompareTriAnMan
commented
Feb 26, 2016
Author
@jasnell Could you review? |
TriAnManforce-pushed
the
doc-readable-encoding-fix
branch
from
February 29, 2016 09:34
eb748a2 to
66bb1b4CompareTriAnMan
commented
Feb 29, 2016
Author
@silverwind thanks! (: |
`readable.setEncoding(null)` - may be the most preferable way to proxy a binary data without any encoding/decoding overhead
TriAnManforce-pushed
the
doc-readable-encoding-fix
branch
from
February 29, 2016 09:56
66bb1b4 to
174fec5CompareTriAnMan
commented
Feb 29, 2016
Author
@silverwind Thanks a lot... Seems I need to install a spell checker for my Sublime. (: |
silverwind
commented
Feb 29, 2016
Contributor
Landed in 8d8fef0. |
silverwind pushed a commit
that referenced
this pull request
Feb 29, 2016
`readable.setEncoding(null)` - may be the most preferable way to proxy a binary data without any encoding/decoding overhead PR-URL: #5155 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Fishrock123 pushed a commit
that referenced
this pull request
Mar 2, 2016
`readable.setEncoding(null)` - may be the most preferable way to proxy a binary data without any encoding/decoding overhead PR-URL: #5155 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
commented
Mar 10, 2016
Contributor
I'm 99% sure this applied to v4. Going to give a day before landing for people to chime in and let me know not to land it |
MylesBorins pushed a commit
that referenced
this pull request
Mar 17, 2016
`readable.setEncoding(null)` - may be the most preferable way to proxy a binary data without any encoding/decoding overhead PR-URL: #5155 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit
that referenced
this pull request
Mar 21, 2016
`readable.setEncoding(null)` - may be the most preferable way to proxy a binary data without any encoding/decoding overhead PR-URL: #5155 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readable.setEncoding(null)- may be the most preferable way to proxy a binary data without any encoding/decoding overheadSee nodejs/readable-stream#180 for details