Skip to content

perf_hooks: add deliveryType and responseStatus fields - #51589

Merged
aduh95 merged 3 commits into
nodejs:mainfrom
KhafraDev:performance-markresource-timing
May 12, 2024
Merged

perf_hooks: add deliveryType and responseStatus fields#51589
aduh95 merged 3 commits into
nodejs:mainfrom
KhafraDev:performance-markresource-timing

Conversation

@KhafraDev

@KhafraDevKhafraDev commented Jan 29, 2024

Copy link
Copy Markdown
Member

Fixes#51001

undici will already work once this change lands.

@nodejs-github-bot

nodejs-github-bot commented Jan 29, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 29, 2024
KhafraDev
KhafraDev commented Jan 29, 2024
View reviewed changes
Comment threadlib/internal/perf/resource_timing.js
initiatorType,
timingInfo,
cacheMode = '',
bodyInfo,

@KhafraDevKhafraDevJan 29, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bodyInfo is currently unused because there's a possible bug where the resource timing is taking fields like encodedBodySize/decodedBodySize from the resource's timing info rather than its resource info.

MmdDebian
MmdDebian reviewed Jan 29, 2024
View reviewed changes

@MmdDebianMmdDebian left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is cool

H4ad
H4ad approved these changes Jan 29, 2024
View reviewed changes

@H4adH4ad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the documentation too?

node/doc/api/perf_hooks.md

Line 249 in 94f824a

### `performance.markResourceTiming(timingInfo, requestedUrl, initiatorType, global, cacheMode)`

Also, adding those fields is not a breaking change?

@KhafraDev

KhafraDev commented Jan 29, 2024

Copy link
Copy Markdown
MemberAuthor

No, they're expected to exist but they weren't implemented.

@H4adH4ad added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 29, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 29, 2024
@nodejs-github-bot

nodejs-github-bot commented Jan 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56956/

anonrig
anonrig approved these changes Jan 29, 2024
View reviewed changes
Comment threaddoc/api/perf_hooks.md
@KhafraDevKhafraDev mentioned this pull request Jan 29, 2024
Merged
7 tasks
mcollina
mcollina approved these changes Jan 30, 2024
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@H4adH4ad added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 15, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 15, 2024
@nodejs-github-bot

nodejs-github-bot commented Feb 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57117/

@legendecaslegendecas added the perf_hooks Issues and PRs related to the implementation of the Performance Timing API. label Mar 5, 2024
@nodejs-github-bot

nodejs-github-bot commented Mar 5, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57586/

@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 14, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 14, 2024
@nodejs-github-bot

nodejs-github-bot commented Apr 14, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58362/

@nodejs-github-bot

nodejs-github-bot commented May 10, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59082/

@KhafraDevKhafraDev added the request-ci Add this label to start a Jenkins CI on a PR. label May 11, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 11, 2024
@nodejs-github-bot

nodejs-github-bot commented May 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59107/

@KhafraDevKhafraDev added the request-ci Add this label to start a Jenkins CI on a PR. label May 12, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 12, 2024
@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented May 12, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59157/

@aduh95
aduh95 merged commit e2697c1 into nodejs:mainMay 12, 2024
@aduh95

aduh95 commented May 12, 2024

Copy link
Copy Markdown
Contributor

Landed in e2697c1

@KhafraDev
KhafraDev deleted the performance-markresource-timing branch May 12, 2024 19:13
targos pushed a commit that referenced this pull request May 12, 2024
@KhafraDev@targos
perf_hooks: add deliveryType and responseStatus fields
1f7c2a9
PR-URL: #51589
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@targos

targos commented May 13, 2024

Copy link
Copy Markdown
Member

This PR adds a feature so it should be labeled semver-minorPRs that contain new features and should be released in the next minor version. (this is not supposed to be done by releasers).

targos added a commit that referenced this pull request May 13, 2024
@targos
2024-05-14, Version 22.2.0 (Current)
7d92816
Notable changes:
cli:
* (SEMVER-MINOR) allow running wasm in limited vmem with
--disable-wasm-trap-handler (Joyee Cheung)
#52766
doc:
* add pimterry to collaborators (Tim Perry)
#52874
fs:
* (SEMVER-MINOR) allow 'withFileTypes' to be used with globs
(Aviv Keller) #52837
inspector:
* (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno)
#52734
lib,src:
* remove --experimental-policy (Rafael Gonzaga)
#52583
perf_hooks:
* (SEMVER-MINOR) add `deliveryType` and `responseStatus` fields
(Matthew Aitken) #51589
test_runner:
* (SEMVER-MINOR) support test plans (Colin Ihrig)
#52860
zlib:
* (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung)
#52692
PR-URL: #52971
@targostargos mentioned this pull request May 13, 2024
Merged
@targostargos added the semver-minor PRs that contain new features and should be released in the next minor version. label May 15, 2024
targos added a commit that referenced this pull request May 15, 2024
@targos
2024-05-15, Version 22.2.0 (Current)
d57af10
Notable changes:
cli:
* (SEMVER-MINOR) allow running wasm in limited vmem with
--disable-wasm-trap-handler (Joyee Cheung)
#52766
doc:
* add pimterry to collaborators (Tim Perry)
#52874
fs:
* (SEMVER-MINOR) allow 'withFileTypes' to be used with globs
(Aviv Keller) #52837
inspector:
* (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno)
#52734
lib,src:
* remove --experimental-policy (Rafael Gonzaga)
#52583
perf_hooks:
* (SEMVER-MINOR) add `deliveryType` and `responseStatus` fields
(Matthew Aitken) #51589
test_runner:
* (SEMVER-MINOR) support test plans (Colin Ihrig)
#52860
zlib:
* (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung)
#52692
PR-URL: #52971
targos added a commit that referenced this pull request May 15, 2024
@targos
2024-05-15, Version 22.2.0 (Current)
28b0a58
Notable changes:
cli:
* (SEMVER-MINOR) allow running wasm in limited vmem with
--disable-wasm-trap-handler (Joyee Cheung)
#52766
doc:
* add pimterry to collaborators (Tim Perry)
#52874
fs:
* (SEMVER-MINOR) allow 'withFileTypes' to be used with globs
(Aviv Keller) #52837
inspector:
* (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno)
#52734
lib,src:
* remove --experimental-policy (Rafael Gonzaga)
#52583
perf_hooks:
* (SEMVER-MINOR) add `deliveryType` and `responseStatus` fields
(Matthew Aitken) #51589
test_runner:
* (SEMVER-MINOR) support test plans (Colin Ihrig)
#52860
zlib:
* (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung)
#52692
PR-URL: #52971
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@KhafraDev@soophoo
perf_hooks: add deliveryType and responseStatus fields
0f9917a
PR-URL: nodejs#51589
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@targos@soophoo
2024-05-15, Version 22.2.0 (Current)
eccd98f
Notable changes:
cli:
* (SEMVER-MINOR) allow running wasm in limited vmem with
--disable-wasm-trap-handler (Joyee Cheung)
nodejs#52766
doc:
* add pimterry to collaborators (Tim Perry)
nodejs#52874
fs:
* (SEMVER-MINOR) allow 'withFileTypes' to be used with globs
(Aviv Keller) nodejs#52837
inspector:
* (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno)
nodejs#52734
lib,src:
* remove --experimental-policy (Rafael Gonzaga)
nodejs#52583
perf_hooks:
* (SEMVER-MINOR) add `deliveryType` and `responseStatus` fields
(Matthew Aitken) nodejs#51589
test_runner:
* (SEMVER-MINOR) support test plans (Colin Ihrig)
nodejs#52860
zlib:
* (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung)
nodejs#52692
PR-URL: nodejs#52971
@skyclouds2001skyclouds2001 mentioned this pull request Nov 8, 2024
Merged
@aviu16aviu16 mentioned this pull request Feb 15, 2026
Closed
@kovankovan mentioned this pull request Mar 11, 2026
Open
@greenheadHQgreenheadHQ mentioned this pull request Aug 4, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@lpincalpincalpinca approved these changes
@anonriganonriganonrig approved these changes
@JungMinuJungMinuJungMinu approved these changes
@legendecaslegendecaslegendecas approved these changes
@H4adH4adH4ad approved these changes
+1 more reviewer
@MmdDebianMmdDebianMmdDebian left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.perf_hooksIssues and PRs related to the implementation of the Performance Timing API.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

performance.markResourceTiming is outdated

11 participants

@KhafraDev@nodejs-github-bot@aduh95@targos@mcollina@lpinca@anonrig@JungMinu@legendecas@H4ad@MmdDebian