Uh oh!
There was an error while loading. Please reload this page.
tools,doc: fix linting errors - #5161
Closed
Trott wants to merge 1 commit into
Closed
Conversation
silverwind
commented
Feb 9, 2016
Contributor
FYI from the CI: LGTM
|
silverwind
commented
Feb 9, 2016
Contributor
Trott
commented
Feb 9, 2016
MemberAuthor
Fire drill. I'm not even joking. Feel free to land. I'll be gone for a while. |
MylesBorins
commented
Feb 9, 2016
Contributor
LGTM if CI is good |
silverwind pushed a commit
that referenced
this pull request
Feb 9, 2016
Refs: #4741 (comment) PR-URL: #5161 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Myles Borins <myles.borins@gmail.com>
silverwind
commented
Feb 9, 2016
Contributor
claudiorodriguez
commented
Feb 9, 2016
Contributor
Thanks for this! |
rvagg pushed a commit
that referenced
this pull request
Feb 10, 2016
Refs: #4741 (comment) PR-URL: #5161 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins
commented
Feb 18, 2016
Contributor
type parser does not exist on v4.x |
silverwind
commented
Feb 18, 2016
Contributor
This depends on #4741. |
MylesBorins
commented
Feb 18, 2016
Contributor
thanks @silverwind updated labels |
MylesBorins pushed a commit
that referenced
this pull request
Feb 22, 2016
Refs: #4741 (comment) PR-URL: #5161 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Feb 22, 2016
Refs: #4741 (comment) PR-URL: #5161 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Mar 2, 2016
Refs: #4741 (comment) PR-URL: #5161 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Myles Borins <myles.borins@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently added linting for files in
tools/docbut PR #4741 was submitted before that tooling was added. It landed without a rebase and test run, so it's breaking CI. This fixes the minor lint issues. Hopefully this can land quickly./cc @fansworld-claudio@silverwind
Refs: #4741 (comment)