Skip to content

test: remove test-fs-stat-bigint flaky designation - #51735

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:remove/flaky-test-fs-stat-bigint
Feb 22, 2024
Merged

test: remove test-fs-stat-bigint flaky designation#51735
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:remove/flaky-test-fs-stat-bigint

Conversation

@lpinca

@lpincalpinca commented Feb 12, 2024

Copy link
Copy Markdown
Member

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 12, 2024
mertcanaltin
mertcanaltin approved these changes Feb 13, 2024
View reviewed changes

@mertcanaltinmertcanaltin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 15, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 15, 2024
@nodejs-github-bot

nodejs-github-bot commented Feb 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57094/

@nodejs-github-bot

nodejs-github-bot commented Feb 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57105/

@nodejs-github-bot

nodejs-github-bot commented Feb 16, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57131/

mhdawson
mhdawson approved these changes Feb 20, 2024
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 22, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 22, 2024
@nodejs-github-bot
nodejs-github-bot merged commit c1fa929 into nodejs:mainFeb 22, 2024
@nodejs-github-bot

nodejs-github-bot commented Feb 22, 2024

Copy link
Copy Markdown
Collaborator

Landed in c1fa929

@lpinca
lpinca deleted the remove/flaky-test-fs-stat-bigint branch February 22, 2024 18:33
marco-ippolito pushed a commit that referenced this pull request Feb 26, 2024
@lpinca@marco-ippolito
test: remove test-fs-stat-bigint flaky designation
11a493d
Refs: #31727 (comment)
PR-URL: #51735
Reviewed-By: Michael Dawson <midawson@redhat.com>
marco-ippolito pushed a commit that referenced this pull request Feb 27, 2024
@lpinca@marco-ippolito
test: remove test-fs-stat-bigint flaky designation
2fb620c
Refs: #31727 (comment)
PR-URL: #51735
Reviewed-By: Michael Dawson <midawson@redhat.com>
@marco-ippolitomarco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@lpinca@richardlau
test: remove test-fs-stat-bigint flaky designation
853b48d
Refs: #31727 (comment)
PR-URL: #51735
Reviewed-By: Michael Dawson <midawson@redhat.com>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@mhdawsonmhdawsonmhdawson approved these changes
@mertcanaltinmertcanaltinmertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lpinca@nodejs-github-bot@mhdawson@mertcanaltin