Uh oh!
There was an error while loading. Please reload this page.
test: fix tests for coverage generation - #51816
Closed
joyeecheung wants to merge 2 commits into
Closed
Conversation
The internal binding profiler is loaded if the test is run with NODE_V8_COVERAGE.
The child process should not inherit NODE_V8_COVERAGE because that clobbers the inspector output the test is checking.
nodejs-github-bot
commented
Feb 20, 2024
Collaborator
Review requested:
|
MoLow
approved these changes
Feb 21, 2024
nodejs-github-bot
commented
Feb 21, 2024
Collaborator
lpinca
approved these changes
Feb 21, 2024
nodejs-github-bot
commented
Feb 21, 2024
Collaborator
nodejs-github-bot
commented
Feb 22, 2024
Collaborator
nodejs-github-bot
commented
Feb 22, 2024
Collaborator
Ethan-Arrowood
approved these changes
Feb 23, 2024
nodejs-github-bot
commented
Feb 25, 2024
Collaborator
nodejs-github-bot
commented
Feb 25, 2024
Collaborator
Landed in db070ee...1353a7b |
nodejs-github-bot pushed a commit
that referenced
this pull request
Feb 25, 2024
The internal binding profiler is loaded if the test is run with NODE_V8_COVERAGE. PR-URL: #51816 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
nodejs-github-bot pushed a commit
that referenced
this pull request
Feb 25, 2024
The child process should not inherit NODE_V8_COVERAGE because that clobbers the inspector output the test is checking. PR-URL: #51816 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
marco-ippolito pushed a commit
that referenced
this pull request
Feb 26, 2024
The internal binding profiler is loaded if the test is run with NODE_V8_COVERAGE. PR-URL: #51816 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
marco-ippolito pushed a commit
that referenced
this pull request
Feb 26, 2024
The child process should not inherit NODE_V8_COVERAGE because that clobbers the inspector output the test is checking. PR-URL: #51816 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
marco-ippolito pushed a commit
that referenced
this pull request
Feb 27, 2024
The internal binding profiler is loaded if the test is run with NODE_V8_COVERAGE. PR-URL: #51816 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
marco-ippolito pushed a commit
that referenced
this pull request
Feb 27, 2024
The child process should not inherit NODE_V8_COVERAGE because that clobbers the inspector output the test is checking. PR-URL: #51816 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Merged
richardlau pushed a commit
that referenced
this pull request
Mar 25, 2024
The internal binding profiler is loaded if the test is run with NODE_V8_COVERAGE. PR-URL: #51816 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
richardlau pushed a commit
that referenced
this pull request
Mar 25, 2024
The child process should not inherit NODE_V8_COVERAGE because that clobbers the inspector output the test is checking. PR-URL: #51816 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: fix test-bootstrap-modules for coverage generation
The internal binding profiler is loaded if the test is run with
NODE_V8_COVERAGE.
test: fix test-debugger-profile for coverage generation
The child process should not inherit NODE_V8_COVERAGE because
that clobbers the inspector output the test is checking.