Uh oh!
There was an error while loading. Please reload this page.
test: split wasi tests - #51836
Merged
Merged
Conversation
nodejs-github-bot
commented
Feb 22, 2024
Collaborator
Review requested:
|
MemberAuthor
When #51834 lands we need to update the status file to only mark the affected test case as flaky (I suspect it's Before the split the wasi tests on my laptop finish in 10s, after it finish in 6s (and it's also the |
nodejs-github-bot
commented
Feb 22, 2024
Collaborator
joyeecheung
commented
Feb 22, 2024
MemberAuthor
The CI shows that test-wasi-poll is indeed what triggers the flake: https://ci.nodejs.org/job/node-test-binary-windows-js-suites/25993/ Rebased and updated the status file to only mark test-wasi-poll as flaky. |
Closed
marco-ippolito
approved these changes
Feb 22, 2024
Move the child process code into a fixture and split the test so that it can be run in parallel and it's easier to identify where the failure is coming from. Also use the spawnSyncAndExitWithoutError() utility so that the test shows complete information on failure. Instead of marking all the wasi tests as flaky, only mark the wasi-poll one which is flaking in the CI now.
Trott
approved these changes
Feb 22, 2024
nodejs-github-bot
commented
Feb 22, 2024
Collaborator
MemberAuthor
CI seemed happy with the wasi tests (Windows still failed due to an rm error) |
nodejs-github-bot
commented
Feb 23, 2024
Collaborator
targos
approved these changes
Feb 23, 2024
nodejs-github-bot
commented
Feb 23, 2024
Collaborator
joyeecheung
commented
Feb 23, 2024
MemberAuthor
Stress tests on Windows for the unmarked tests: https://ci.nodejs.org/view/Stress/job/node-stress-single-test/474/ |
nodejs-github-bot
commented
Feb 23, 2024
Collaborator
nodejs-github-bot
commented
Feb 24, 2024
Collaborator
Landed in a5376c5 |
marco-ippolito pushed a commit
that referenced
this pull request
Feb 26, 2024
Move the child process code into a fixture and split the test so that it can be run in parallel and it's easier to identify where the failure is coming from. Also use the spawnSyncAndExitWithoutError() utility so that the test shows complete information on failure. Instead of marking all the wasi tests as flaky, only mark the wasi-poll one which is flaking in the CI now. PR-URL: #51836 Refs: #51822 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
marco-ippolito pushed a commit
that referenced
this pull request
Feb 27, 2024
Move the child process code into a fixture and split the test so that it can be run in parallel and it's easier to identify where the failure is coming from. Also use the spawnSyncAndExitWithoutError() utility so that the test shows complete information on failure. Instead of marking all the wasi tests as flaky, only mark the wasi-poll one which is flaking in the CI now. PR-URL: #51836 Refs: #51822 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
richardlau pushed a commit
that referenced
this pull request
Mar 25, 2024
Move the child process code into a fixture and split the test so that it can be run in parallel and it's easier to identify where the failure is coming from. Also use the spawnSyncAndExitWithoutError() utility so that the test shows complete information on failure. Instead of marking all the wasi tests as flaky, only mark the wasi-poll one which is flaking in the CI now. PR-URL: #51836 Refs: #51822 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the child process code into a fixture and split the test
so that it can be run in parallel and it's easier to identify
where the failure is coming from. Also use the
spawnSyncAndExitWithoutError() utility so that the test shows
complete information on failure.
Instead of marking all the wasi tests as flaky, only mark the
wasi-poll one which is flaking in the CI now.
Refs: #51822