Uh oh!
There was an error while loading. Please reload this page.
doc,loaders,module: clarify hook chain execution sequence - #51884
Conversation
nodejs-github-bot
commented
Feb 26, 2024
Review requested:
|
yklcs
commented
Feb 27, 2024
I'd like to suggest making changes in the "hooks" section too for clarity, as it also mentions chaining. The "subsequent loader" part, in specific. Lines 376 to 380 in 6bb7c4d |
Uh oh!
There was an error while loading. Please reload this page.
Hmm, here I'm not seeing the confusing bit. Do you mean you'd like some indication of which loader will be in - which is a reference to the subsequent loader's hook.+ which is a reference to the subsequent loader's hook (in LIFO order). |
yklcs
commented
Feb 28, 2024
I think that would help, maybe along with a link to |
link to chaining from hooks & mention LIFO
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
nodejs-github-bot
commented
Mar 1, 2024
This comment was marked as resolved.
This comment was marked as resolved.
nodejs-github-bot
commented
Mar 2, 2024
nodejs-github-bot
commented
Mar 2, 2024
Landed in 2e2a848 |
PR-URL: #51884 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
PR-URL: #51884 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Closes#51876
Closes#51878