Skip to content

http: use localAddress instead of path - #5190

Closed
dirceu wants to merge 1 commit into
nodejs:masterfrom
dirceu:fixes-5051
Closed

http: use localAddress instead of path#5190
dirceu wants to merge 1 commit into
nodejs:masterfrom
dirceu:fixes-5051

Conversation

@dirceu

@dirceudirceu commented Feb 11, 2016

Copy link
Copy Markdown
Contributor

Fix options usage on lib/_http_agent.js for the Legacy API.

Fixes: #5051

@mscdexmscdex added the http Issues or PRs related to the http subsystem. label Feb 11, 2016
@evanlucas

evanlucas commented Feb 11, 2016

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/1633/

@jasnell

jasnell commented Feb 11, 2016

Copy link
Copy Markdown
Member

/cc @nodejs/http

@mscdex

mscdex commented Feb 11, 2016

Copy link
Copy Markdown
Contributor

LGTM

@evanlucas

evanlucas commented Feb 14, 2016

Copy link
Copy Markdown
Contributor

LGTM. Maybe this is something that we should run citgm on first? /cc @thealphanerd

@jasnell

jasnell commented Mar 21, 2016

Copy link
Copy Markdown
Member

New CI: https://ci.nodejs.org/job/node-test-pull-request/2002/

@jasnell

jasnell commented Mar 21, 2016

Copy link
Copy Markdown
Member

@nodejs/ctc ... anyone have any concerns with this one?

@MylesBorins

MylesBorins commented Mar 24, 2016

Copy link
Copy Markdown
Contributor

citgm: https://ci.nodejs.org/job/thealphanerd-smoker/127/

@estliberitas
estliberitasforce-pushed the master branch 2 times, most recently from 7da4fd4 to c7066fbCompareApril 26, 2016 05:23
@MylesBorins

MylesBorins commented May 9, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

Running test suites one more time. Is anyone opposed to this landing if everything is green?

ci: https://ci.nodejs.org/job/node-test-pull-request/2551/
citgm: https://ci.nodejs.org/view/Node.js-citgm/job/thealphanerd-smoker/256/

edit: we are having issues with citgm in CI right now... figuring out what is going on, ignore results in the mean time

@MylesBorinsMylesBorins self-assigned this May 9, 2016
@bnoordhuis

bnoordhuis commented May 10, 2016

Copy link
Copy Markdown
Member

LGTM but there are a few style violations in the test that need to be fixed. make jslint will point them out.

@dirceu
http: use localAddress instead of path
cd4c6b5
Fix `options` usage on `lib/_http_agent.js` for the Legacy API.
Fixes: nodejs#5051
@dirceu

dirceu commented May 10, 2016

Copy link
Copy Markdown
ContributorAuthor

@bnoordhuis thanks! I've updated the test file, and there are no more jslint errors.

@bnoordhuis

bnoordhuis commented May 10, 2016

Copy link
Copy Markdown
Member

LGTM. CI: https://ci.nodejs.org/job/node-test-pull-request/2560/

@MylesBorins

MylesBorins commented May 10, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

citgm: https://ci.nodejs.org/view/Node.js-citgm/job/thealphanerd-smoker/261/

Hopefully the CI problems we were seeing yesterday should be resolved

@bnoordhuis

bnoordhuis commented May 11, 2016

Copy link
Copy Markdown
Member

CI is green, citgm is taking too long to load here.

@jasnell

jasnell commented May 11, 2016

Copy link
Copy Markdown
Member

LGTM

@MylesBorins

MylesBorins commented May 16, 2016

Copy link
Copy Markdown
Contributor

citgm: https://ci.nodejs.org/job/thealphanerd-smoker/270/

if it is green I will land this

bnoordhuis pushed a commit that referenced this pull request May 19, 2016
@dirceu@bnoordhuis
http: use localAddress instead of path
fe77de1
Fix `options` usage on `lib/_http_agent.js` for the Legacy API.
Fixes: #5051
PR-URL: #5190
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@bnoordhuis

bnoordhuis commented May 19, 2016

Copy link
Copy Markdown
Member

CITGM is green. Landed in fe77de1, thanks Dirceu.

Fishrock123 pushed a commit that referenced this pull request May 23, 2016
@dirceu@Fishrock123
http: use localAddress instead of path
a3b3a47
Fix `options` usage on `lib/_http_agent.js` for the Legacy API.
Fixes: #5051
PR-URL: #5190
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins

MylesBorins commented Jun 1, 2016

Copy link
Copy Markdown
Contributor

how long should this stay on v6 before a backport?

rvagg pushed a commit that referenced this pull request Jun 2, 2016
@dirceu@rvagg
http: use localAddress instead of path
2ab3609
Fix `options` usage on `lib/_http_agent.js` for the Legacy API.
Fixes: #5051
PR-URL: #5190
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins

MylesBorins commented Jun 29, 2016

Copy link
Copy Markdown
Contributor

ping @nodejs/http re: backport

@MylesBorins

MylesBorins commented Aug 30, 2016

Copy link
Copy Markdown
Contributor

@nodejs/lts is this something we want to see land on v4.x?

@MylesBorinsMylesBorins removed their assignment Dec 27, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

httpIssues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dirceu@evanlucas@jasnell@mscdex@MylesBorins@bnoordhuis