Uh oh!
There was an error while loading. Please reload this page.
fs: expose glob and globSync - #51912
Conversation
this capability was originally added to core for the use of the test runner, and we did not expose it since some dependencies don't use primordials. |
The
notable-change Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
There was a problem hiding this comment.
this is pretty much the same implementation as globSync except using yield instead if this.#results.push
There was a problem hiding this comment.
The implementations can be unified probably if you yield where you await and then do sync/async I/O depending on the path not sure if it's worth it
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
MoLow
commented
Feb 29, 2024
CC @nodejs/fs |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
aduh95
commented
Mar 2, 2024
/cc @nodejs/fs |
atlowChemi
commented
Mar 3, 2024
cc @nodejs/primordials |
nodejs-github-bot
commented
Mar 3, 2024
styfle
commented
May 4, 2024
@jonschlinkert It might be worth creating a new issue since this one is closed |
danielbayley
commented
Jun 22, 2024
@jonschlinkert@styfle See: #53547. |
Fixes#40731
This PR introduces
fs.globandfsPromises.glob.