Skip to content

Revert "build: workaround for node-core-utils" - #51975

Merged
nodejs-github-bot merged 1 commit into
mainfrom
fix-auto-start-ci
Mar 5, 2024
Merged

Revert "build: workaround for node-core-utils"#51975
nodejs-github-bot merged 1 commit into
mainfrom
fix-auto-start-ci

Conversation

@richardlau

@richardlaurichardlau commented Mar 5, 2024

Copy link
Copy Markdown
Member

This reverts commit b2a6083.

The auto-start-ci workflow is currently broken by the latest node-core-utils. e.g.
https://github.com/nodejs/node/actions/runs/8158770866/job/22301449831#step:6:17 (note the workflow passed but failed to start any CIs)

/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/undici/lib/web/fetch/response.js:507 ReadableStream ^ReferenceError: ReadableStream is not defined at Object.<anonymous> (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/undici/lib/web/fetch/response.js:507:3) at Module._compile (node:internal/modules/cjs/loader:1198:14) at Object.Module._extensions..js (node:internal/modules/cjs/loader:1252:10) at Module.load (node:internal/modules/cjs/loader:1076:32) at Function.Module._load (node:internal/modules/cjs/loader:911:12) at Module.require (node:internal/modules/cjs/loader:1100:19) at require (node:internal/modules/cjs/helpers:119:[18](https://github.com/nodejs/node/actions/runs/8158770866/job/22301449831#step:6:19)) at Object.<anonymous> (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/undici/lib/web/fetch/index.js:11:5) at Module._compile (node:internal/modules/cjs/loader:1[19](https://github.com/nodejs/node/actions/runs/8158770866/job/22301449831#step:6:20)8:14) at Object.Module._extensions..js (node:internal/modules/cjs/loader:1[25](https://github.com/nodejs/node/actions/runs/8158770866/job/22301449831#step:6:26)2:10)

From @targos in Slack:

The workflow should be updated, Node.js 16 support was removed in https://github.com/nodejs/node-core-utils/releases/tag/v4.0.0
Also node-fetch was removed by https://github.com/nodejs/node-core-utils/pull/666/files

@nodejs-github-bot

nodejs-github-bot commented Mar 5, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 5, 2024
Trott
Trott approved these changes Mar 5, 2024
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 5, 2024
@github-actions

github-actionsBot commented Mar 5, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 5, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 5, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 5a967a8 into mainMar 5, 2024
@nodejs-github-bot

nodejs-github-bot commented Mar 5, 2024

Copy link
Copy Markdown
Collaborator

Landed in 5a967a8

@nodejs-github-bot
nodejs-github-bot deleted the fix-auto-start-ci branch March 5, 2024 16:52
targos pushed a commit that referenced this pull request Mar 7, 2024
@richardlau@targos
Revert "build: workaround for node-core-utils"
fd86ea8
This reverts commit b2a6083.
PR-URL: #51975
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
@targostargos mentioned this pull request Mar 7, 2024
Merged
richardlau added a commit that referenced this pull request Mar 25, 2024
@richardlau
Revert "build: workaround for node-core-utils"
9f5547a
This reverts commit b2a6083.
PR-URL: #51975
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@anonriganonriganonrig approved these changes

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@richardlau@nodejs-github-bot@Trott@anonrig