Uh oh!
There was an error while loading. Please reload this page.
doc: improvements to console.markdown copy - #5225
Conversation
There was a problem hiding this comment.
Maybe this should instead be:
... to write to `process.stdout` and `process.stderr`.
There was a problem hiding this comment.
Yep, I thought so too, but was waiting for this comment 😄
There was a problem hiding this comment.
Hmm, multiple places in this file refer to the standard output streams as just stdout, stderr. I think it's better to keep this paragraph unchanged for consistency.
There was a problem hiding this comment.
@mscdex your thoughts? I agree with both of you, to say, so not sure. From one point, it's OK to use stdout or "process stdout" because, it's how it is. Other point is let people understand that global console uses process.stdout and process.stderr Writable streams. Both points are good to me.
There was a problem hiding this comment.
I guess I don't really mind either way, as long as it's all consistent.
Fix missing links. Fix styling of printf() - once #5073 lands, link to man page will be auto-generated. Fix several typos.
silverwind
commented
Feb 16, 2016
LGTM |
1 similar comment
jasnell
commented
Feb 16, 2016
LGTM |
silverwind
commented
Feb 17, 2016
Landed in fb502ef. |
Fix missing links. Fix styling of printf() - once #5073 lands, link to man page will be auto-generated. Fix several typos.