Uh oh!
There was an error while loading. Please reload this page.
build: Fix headers install for shared mode on Windows - #52277
Closed
segevfiner wants to merge 1 commit into
Closed
Conversation
segevfinerforce-pushed
the
fix-shared-node-windows-headers-install
branch
from
March 30, 2024 19:39
cffef86 to
619768aCompareStefanStojanovic
approved these changes
Apr 1, 2024
StefanStojanovic
left a comment
Contributor
There was a problem hiding this comment.
I've tested the fix and can confirm it works.
anonrig
approved these changes
Apr 10, 2024
nodejs-github-bot
commented
Apr 10, 2024
Collaborator
nodejs-github-bot
commented
Apr 12, 2024
Collaborator
segevfiner
commented
Apr 29, 2024
ContributorAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix headers install for shared mode on Windows.
Note that
config_gypi_pathis used relative to the working dir in the main part of the script, but is later resolved according to root-dir when trying to use it again later in the script, so I made the path to it absolute.