Uh oh!
There was an error while loading. Please reload this page.
lib: adds colors to X's and .'s in test_runner dot reporter - #52278
lib: adds colors to X's and .'s in test_runner dot reporter#52278Aidan7757 wants to merge 3 commits into
Conversation
nodejs-github-bot
commented
Mar 30, 2024
Review requested:
|
MoLow
commented
Mar 31, 2024
Please fix the commit message, and update snapshots ( |
benjamingr
left a comment
There was a problem hiding this comment.
Good start, see Moshe's comments on how to proceed, thanks 🙏
Aidan7757
commented
Mar 31, 2024
Hi, I'm getting a zsh: Permission Denied when attempting to update the snapshots. |
MoLow
commented
Mar 31, 2024
perhaps you checked out the repo with another user/with sudo? you might need to |
5a34ba4 to
8dc7c8aCompareAidan7757
commented
Apr 1, 2024
Just reworked the commit message and ran the command given after being able to get access. I'm unsure of the purpose of snapshots - it ended up returning errors that were contained in a file I had no touched and I'm unsure of what to do with the statements returned. Any advice would be appreciated, thanks for all the help! Errors returned from snapshot: Thanks! |
MoLow
commented
Apr 1, 2024
Snapshot tests are in place to validate that the output of test runner reporters stays the same across commits. |
Aidan7757
commented
Apr 1, 2024
Yes, the error persists on the main branch. |
atlowChemi
commented
Apr 1, 2024
Awesome!
As Moshe explained, snapshots are files containing the expected output for a test. We use these to ensure the reporters work as expected as well as other things, and as this PR proposes a change to the
Does rebuilding the Nodejs executable work? ( |
Aidan7757
commented
Apr 2, 2024
Calling make -j4 returns an error of: Sorry for all of the issues! I appreciate all of the aid given and hopefully theres an easy solution hidden in plain sight that I'm just missing, I'll keep digging for it. |
atlowChemi
commented
Apr 2, 2024
Could you try pasting the entire output, or the error throughout the process? |
Aidan7757
commented
Apr 2, 2024
Fortunately the make -j4 appears to have fixed the issue and the Does this mean that the code is able to be submitted? There are still a few checks that appear to be failing within the pull request. |
MoLow
commented
Apr 2, 2024
you should commit all changed snapshot files that are changed by |
MoLow
commented
Jun 5, 2024
Hey @Aidan7757 are you still interested in implementing this? |
Closing in favor of #53450, which implements a similar change, and has (an) approval(s). |
Refs: #51770
First time contributing - if there are any procedural or code changes that need to be made let me know. Thanks!
Aidan Chadha