Skip to content

src: stop using v8::BackingStore::Reallocate - #52292

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:fix-52234
Apr 5, 2024
Merged

src: stop using v8::BackingStore::Reallocate#52292
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:fix-52234

Conversation

@targos

@targostargos commented Mar 31, 2024

Copy link
Copy Markdown
Member

It's being deprecated by V8.
Explicitly allocate a new ArrayBuffer and copy the data instead.

Fixes: #52234

@nodejs-github-bot

nodejs-github-bot commented Mar 31, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/http2
  • @nodejs/net

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 31, 2024
joyeecheung
joyeecheung reviewed Mar 31, 2024
View reviewed changes

@joyeecheungjoyeecheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions to avoid the copy when the size is the same.

(I do wonder now that we can't shrink the backing store in place, is there any benefit in allocating them on the V8 heap instead of using externally-managed buffers that we can realloc()? At least when we shrink externally-managed buffers we don't need to do the copy and it'll be cheaper. But that can be left as a TODO after we get rid of the deprecated API).

Comment threadsrc/crypto/crypto_cipher.cc Outdated
Comment threadsrc/crypto/crypto_cipher.cc Outdated
Comment threadsrc/crypto/crypto_cipher.cc Outdated
Comment threadsrc/crypto/crypto_sig.cc Outdated
Comment threadsrc/node_http2.cc Outdated
Comment threadsrc/stream_base.cc Outdated
Comment threadsrc/udp_wrap.cc Outdated
@targos

targos commented Mar 31, 2024

Copy link
Copy Markdown
MemberAuthor

Updated!

@targos

targos commented Mar 31, 2024

Copy link
Copy Markdown
MemberAuthor

Something's wrong with the new changes.

@targos@joyeecheung
src: stop using v8::BackingStore::Reallocate
d5adde1
It's being deprecated by V8.
Explicitly allocate a new ArrayBuffer and copy the data when needed
instead.
Fixes: nodejs#52234
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2024
@nodejs-github-bot

nodejs-github-bot commented Mar 31, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58018/

@nodejs-github-bot

nodejs-github-bot commented Apr 1, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58021/

@nodejs-github-bot

nodejs-github-bot commented Apr 1, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58024/

@nodejs-github-bot

nodejs-github-bot commented Apr 1, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58026/

@targos
targos requested a review from joyeecheungApril 1, 2024 08:41
@nodejs-github-bot

nodejs-github-bot commented Apr 1, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58031/

@targostargos added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 5, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 5, 2024
@nodejs-github-bot
nodejs-github-bot merged commit ec15504 into nodejs:mainApr 5, 2024
@nodejs-github-bot

nodejs-github-bot commented Apr 5, 2024

Copy link
Copy Markdown
Collaborator

Landed in ec15504

@targos
targos deleted the fix-52234 branch April 5, 2024 09:38
@RafaelGSSRafaelGSS mentioned this pull request Apr 15, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@targos@joyeecheung@marco-ippolito
src: stop using v8::BackingStore::Reallocate
9b239cd
It's being deprecated by V8.
Explicitly allocate a new ArrayBuffer and copy the data when needed
instead.
Fixes: #52234
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #52292
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@marco-ippolitomarco-ippolito mentioned this pull request May 2, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
@targos@joyeecheung@marco-ippolito
src: stop using v8::BackingStore::Reallocate
7e35a16
It's being deprecated by V8.
Explicitly allocate a new ArrayBuffer and copy the data when needed
instead.
Fixes: #52234
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #52292
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@sygsyg mentioned this pull request May 8, 2024
Merged
@lemirelemire mentioned this pull request Jun 23, 2024
Closed
tniessen added a commit to tniessen/node that referenced this pull request Apr 8, 2025
@tniessen
src: remove void* -> char* -> void* casts
f282307
When passing the return value of `BackingStore::Data()` as the first or
second argument to `memcpy()`, it is unnecessary to cast the returned
pointer to `char*`.
Refs: nodejs#52292
@tniessentniessen mentioned this pull request Apr 8, 2025
Merged
nodejs-github-bot pushed a commit that referenced this pull request Apr 10, 2025
@tniessen
src: remove void* -> char* -> void* casts
8dce721
When passing the return value of `BackingStore::Data()` as the first or
second argument to `memcpy()`, it is unnecessary to cast the returned
pointer to `char*`.
Refs: #52292
PR-URL: #57791
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@tniessen@RafaelGSS
src: remove void* -> char* -> void* casts
c1edf5a
When passing the return value of `BackingStore::Data()` as the first or
second argument to `memcpy()`, it is unnecessary to cast the returned
pointer to `char*`.
Refs: #52292
PR-URL: #57791
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@tniessen@RafaelGSS
src: remove void* -> char* -> void* casts
d50b8a8
When passing the return value of `BackingStore::Data()` as the first or
second argument to `memcpy()`, it is unnecessary to cast the returned
pointer to `char*`.
Refs: #52292
PR-URL: #57791
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@tniessen@aduh95
src: remove void* -> char* -> void* casts
a1af28b
When passing the return value of `BackingStore::Data()` as the first or
second argument to `memcpy()`, it is unnecessary to cast the returned
pointer to `char*`.
Refs: #52292
PR-URL: #57791
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@tniessen@RafaelGSS
src: remove void* -> char* -> void* casts
cd12d1c
When passing the return value of `BackingStore::Data()` as the first or
second argument to `memcpy()`, it is unnecessary to cast the returned
pointer to `char*`.
Refs: #52292
PR-URL: #57791
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@tniessen@aduh95
src: remove void* -> char* -> void* casts
341fb33
When passing the return value of `BackingStore::Data()` as the first or
second argument to `memcpy()`, it is unnecessary to cast the returned
pointer to `char*`.
Refs: #52292
PR-URL: #57791
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@tniessen@aduh95
src: remove void* -> char* -> void* casts
a02fa22
When passing the return value of `BackingStore::Data()` as the first or
second argument to `memcpy()`, it is unnecessary to cast the returned
pointer to `char*`.
Refs: #52292
PR-URL: #57791
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@tniessen@aduh95
src: remove void* -> char* -> void* casts
108a101
When passing the return value of `BackingStore::Data()` as the first or
second argument to `memcpy()`, it is unnecessary to cast the returned
pointer to `char*`.
Refs: #52292
PR-URL: #57791
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95 pushed a commit that referenced this pull request May 19, 2025
@tniessen@aduh95
src: remove void* -> char* -> void* casts
648ad25
When passing the return value of `BackingStore::Data()` as the first or
second argument to `memcpy()`, it is unnecessary to cast the returned
pointer to `char*`.
Refs: #52292
PR-URL: #57791
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@tniessentniessentniessen approved these changes
@joyeecheungjoyeecheungAwaiting requested review from joyeecheung

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Please stop using v8::BackingStore::Reallocate

5 participants

@targos@nodejs-github-bot@addaleax@tniessen@joyeecheung