fs: fixes recursive fs.watch crash on Linux when deleting files by mcollina · Pull Request #52349 · nodejs/node

- Loading data for nodejs/node/pull/52349 ✔ Done loading data for nodejs/node/pull/52349 ----------------------------------- PR info ------------------------------------ Title fs: fixes recursive fs.watch crash on Linux when deleting files (#52349) Author Matteo Collina (@mcollina) Branch mcollina:fix-52018 -> nodejs:main Labels fs, author ready, needs-ci, lts-watch-v20.x Commits 10 - fs: fixes recursive fs.watch crash on Linux when deleting files - fixup - fixup - Update test/parallel/test-fs-watch-recursive-delete.js - fixup - fixup - fixup - fixup - fixup - fixup Committers 2 - Matteo Collina - GitHub PR-URL: https://github.com/nodejs/node/pull/52349 Fixes: https://github.com/nodejs/node/issues/52018 Reviewed-By: Yagiz Nizipli Reviewed-By: Moshe Atlow ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52349 Fixes: https://github.com/nodejs/node/issues/52018 Reviewed-By: Yagiz Nizipli Reviewed-By: Moshe Atlow -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 03 Apr 2024 14:42:00 GMT ✔ Approvals: 2 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/52349#pullrequestreview-2009056028 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/52349#pullrequestreview-2009091163 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-04-18T17:34:54Z: https://ci.nodejs.org/job/node-test-pull-request/58502/ - Querying data for job/node-test-pull-request/58502/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 52349 From https://github.com/nodejs/node * branch refs/pull/52349/merge -> FETCH_HEAD ✔ Fetched commits as 580aae58f62c..3a358b291a3f -------------------------------------------------------------------------------- [main 0211a26868] fs: fixes recursive fs.watch crash on Linux when deleting files Author: Matteo Collina Date: Wed Apr 3 16:40:46 2024 +0200 2 files changed, 32 insertions(+), 3 deletions(-) create mode 100644 test/parallel/test-fs-watch-recursive-delete.js [main ddb4e31ca1] fixup Author: Matteo Collina Date: Wed Apr 3 16:52:27 2024 +0200 2 files changed, 13 insertions(+), 17 deletions(-) [main e4e2bebb2d] fixup Author: Matteo Collina Date: Thu Apr 11 11:45:50 2024 +0200 1 file changed, 2 insertions(+), 1 deletion(-) [main d23c7c8330] Update test/parallel/test-fs-watch-recursive-delete.js Author: Matteo Collina Date: Thu Apr 11 11:46:31 2024 +0200 1 file changed, 3 insertions(+), 2 deletions(-) [main 6669dac5e8] fixup Author: Matteo Collina Date: Thu Apr 11 11:47:23 2024 +0200 1 file changed, 2 insertions(+), 3 deletions(-) [main 1c8c1ef7f9] fixup Author: Matteo Collina Date: Thu Apr 11 13:37:38 2024 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [main e08d7b4c34] fixup Author: Matteo Collina Date: Thu Apr 11 15:43:11 2024 +0200 1 file changed, 6 insertions(+), 4 deletions(-) [main 61410fe592] fixup Author: Matteo Collina Date: Thu Apr 11 16:54:50 2024 +0200 1 file changed, 6 insertions(+), 2 deletions(-) [main 14cf96222c] fixup Author: Matteo Collina Date: Thu Apr 18 16:18:58 2024 +0200 1 file changed, 3 insertions(+) [main 0cb4e9b123] fixup Author: Matteo Collina Date: Thu Apr 18 16:26:10 2024 +0200 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 10 commits in the PR. Attempting autorebase. Rebasing (2/20)

Executing: git node land --amend --yes
⚠ Found Fixes: #52018, skipping..
--------------------------------- New Message ----------------------------------
fs: fixes recursive fs.watch crash on Linux when deleting files

Signed-off-by: Matteo Collina hello@matteocollina.com
Fixes: #52018
PR-URL: #52349
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io
Reviewed-By: Moshe Atlow moshe@atlow.co.il

[detached HEAD 0a2ab5f5f4] fs: fixes recursive fs.watch crash on Linux when deleting files
Author: Matteo Collina hello@matteocollina.com
Date: Wed Apr 3 16:40:46 2024 +0200
2 files changed, 32 insertions(+), 3 deletions(-)
create mode 100644 test/parallel/test-fs-watch-recursive-delete.js
Rebasing (3/20)
Rebasing (4/20)