Uh oh!
There was an error while loading. Please reload this page.
lib: Rename readme.md to README.md - #52471
Merged
Merged
Conversation
avivkeller
commented
Apr 11, 2024
MemberAuthor
Despite the need-ci label, this PR does not need a ci run. |
aduh95
approved these changes
Apr 11, 2024
avivkeller
commented
Apr 11, 2024
MemberAuthor
I'm fixing the PR message now; cloning the repo is slow. |
aduh95
commented
Apr 11, 2024
Contributor
No worries, it can also be done upon landing. |
avivkeller
commented
Apr 11, 2024
MemberAuthor
Renamed! |
deokjinkim
approved these changes
Apr 11, 2024
lpinca
approved these changes
Apr 12, 2024
UlisesGascon
approved these changes
Apr 12, 2024
avivkeller
commented
Apr 13, 2024
MemberAuthor
I don't that "author ready" means I need to do anything, so are we good to merge? |
marco-ippolito
approved these changes
Apr 14, 2024
nodejs-github-bot
commented
Apr 14, 2024
Collaborator
Landed in f8e325e |
aduh95 pushed a commit
that referenced
this pull request
Apr 29, 2024
PR-URL: #52471 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52471 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
marco-ippolito pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52471 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames
readme.mdtoREADME.mdfor easier find-ability. (I know I made a typo on the commit message, I can amend it before we merge)