Uh oh!
There was an error while loading. Please reload this page.
node-api: address coverity report - #52584
Merged
Merged
Conversation
Address missing initialization reported by coverity Signed-off-by: Michael Dawson <midawson@redhat.com>
nodejs-github-bot
commented
Apr 18, 2024
Collaborator
Review requested:
|
MemberAuthor
Report from coverity classExternalWrapper {
835private:2. uninit_member: Non-staticclassmember type_tag_.lower is not initialized in this constructor nor in any functions that it calls.
CID361482: (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member type_tag_.upper is not initialized in this constructor nor in any functions that it calls.
836 explicit ExternalWrapper(void* data) : data_(data) {}
837838staticvoidWeakCallback(const v8::WeakCallbackInfo<ExternalWrapper>& data) {
839 ExternalWrapper* wrapper = data.GetParameter();
840delete wrapper;
841 } |
vmoroz
commented
Apr 19, 2024
Member
It is a good fix. Though in this code we must not be affected by the not-initialized variable because it is guarded by the Boolean flag |
legendecas
approved these changes
Apr 19, 2024
gabrielschulhof
approved these changes
Apr 19, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Flarna
approved these changes
Apr 22, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Apr 26, 2024
Collaborator
nodejs-github-bot
commented
Apr 26, 2024
Collaborator
Landed in e4c1d02 |
aduh95 pushed a commit
that referenced
this pull request
Apr 29, 2024
Address missing initialization reported by coverity Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #52584 Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
marco-ippolito pushed a commit
that referenced
this pull request
May 2, 2024
Address missing initialization reported by coverity Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #52584 Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Merged
marco-ippolito pushed a commit
that referenced
this pull request
May 3, 2024
Address missing initialization reported by coverity Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #52584 Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
soophoo pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
Address missing initialization reported by coverity Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: nodejs#52584 Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address missing initialization reported by coverity