Uh oh!
There was an error while loading. Please reload this page.
test: fix backtick usage in docs - #52643
Merged
Merged
Conversation
cola119
approved these changes
Apr 23, 2024
nodejs-github-bot
commented
Apr 23, 2024
Collaborator
lpinca
approved these changes
Apr 23, 2024
avivkeller
commented
Apr 23, 2024
MemberAuthor
The CI failed due to a disconnected runner/agent, should we re-run it, or leave it? |
nodejs-github-bot
commented
Apr 23, 2024
Collaborator
MoLow
approved these changes
Apr 24, 2024
nodejs-github-bot
commented
Apr 24, 2024
Collaborator
nodejs-github-bot
commented
Apr 24, 2024
Collaborator
cola119
commented
Apr 24, 2024
Member
I restarted the CI, let's wait until everything turns green. |
MoLow
commented
Apr 24, 2024
Member
@cola119 please use the "resume build" option next time to avoid running a full CI |
nodejs-github-bot
commented
Apr 24, 2024
Collaborator
nodejs-github-bot
commented
Apr 24, 2024
Collaborator
nodejs-github-bot
commented
Apr 24, 2024
Collaborator
Landed in fa62544 |
aduh95 pushed a commit
that referenced
this pull request
Apr 29, 2024
PR-URL: #52643 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the tests, which cause similar CLI flags to get mixed up when testing for them in the documentation
(Ref: #52593)
Before this change, the following would both get treated as
--my-foo(in the tests, not the actual CLI parsing)