Uh oh!
There was an error while loading. Please reload this page.
quic: address recent coverity warnings - #52647
Closed
mhdawson wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Michael Dawson <midawson@redhat.com>
mhdawson
commented
Apr 22, 2024
MemberAuthor
This is an example of the recent warnings that showed up: 85QuicError QuicError::ForTransport(error_code code, std::string reason) {
1. move: reason is moved (indicated by std::move(reason)).
286 QuicError error(std::move(reason));
CID362781: (#1 of 1): Using a moved object (USE_AFTER_MOVE)
2. use_after_move: reason is used after it has been already moved.
287ngtcp2_ccerr_set_transport_error(
288 &error.error_, code, error.reason_c_str(), reason.length());
289return error;
290} |
mhdawson
commented
Apr 22, 2024
MemberAuthor
@nodejs/quic FYI |
vmoroz
commented
Apr 22, 2024
Member
Currently quic cctest is failing on Windows. Hopefully this PR must fix them. |
nodejs-github-bot
commented
Apr 23, 2024
Collaborator
nodejs-github-bot
commented
Apr 25, 2024
Collaborator
jasnell
approved these changes
Apr 27, 2024
nodejs-github-bot
commented
Apr 27, 2024
Collaborator
mertcanaltin
approved these changes
Apr 28, 2024
mhdawson added a commit
that referenced
this pull request
Apr 29, 2024
Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #52647 Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: James M Snell <jasnell@gmail.com>
mhdawson
commented
Apr 29, 2024
MemberAuthor
Landed in d2ebaaa |
aduh95 pushed a commit
that referenced
this pull request
Apr 30, 2024
Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #52647 Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: James M Snell <jasnell@gmail.com>
soophoo pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: nodejs#52647 Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.