Uh oh!
There was an error while loading. Please reload this page.
typings: fix invalid JSDoc declarations - #52659
Merged
Merged
Conversation
nodejs-github-bot
commented
Apr 24, 2024
Collaborator
Review requested:
|
GeoffreyBooth
approved these changes
Apr 24, 2024
GeoffreyBooth
left a comment
Member
There was a problem hiding this comment.
I think you mean invalid jsdoc not invalid jsconfig.
lpinca
approved these changes
Apr 24, 2024
marco-ippolito
approved these changes
Apr 24, 2024
VoltrexKeyva
approved these changes
Apr 24, 2024
avivkeller
commented
Apr 24, 2024
Member
Adding typings (jsdoc) |
JakobJingleheimer
approved these changes
Apr 24, 2024
Contributor
Fast-track has been requested by @aduh95. Please 👍 to approve. |
MoLow
approved these changes
Apr 24, 2024
nodejs-github-bot
commented
Apr 24, 2024
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/52659 ✔ Done loading data for nodejs/node/pull/52659 ----------------------------------- PR info ------------------------------------ Title typings: fix invalid JSDoc declarations (#52659) Author Yagiz Nizipli (@anonrig) Branch anonrig:fix-jsdoc -> nodejs:main Labels esm, fast-track, author ready, typings Commits 1 - lib: fix invalid jsconfig declarations Committers 1 - Yagiz Nizipli PR-URL: https://github.com/nodejs/node/pull/52659 Reviewed-By: Geoffrey Booth Reviewed-By: Luigi Pinca Reviewed-By: Marco Ippolito Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Jacob Smith Reviewed-By: Moshe Atlow ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52659 Reviewed-By: Geoffrey Booth Reviewed-By: Luigi Pinca Reviewed-By: Marco Ippolito Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Jacob Smith Reviewed-By: Moshe Atlow -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 24 Apr 2024 02:54:00 GMT ✔ Approvals: 6 ✔ - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/52659#pullrequestreview-2018782305 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/52659#pullrequestreview-2018913700 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/52659#pullrequestreview-2019497030 ✔ - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/52659#pullrequestreview-2019907090 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/52659#pullrequestreview-2020020918 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/52659#pullrequestreview-2020269480 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8819523502 |
aduh95
commented
Apr 24, 2024
Contributor
Landed in 1df52e6 |
aduh95 pushed a commit
that referenced
this pull request
Apr 29, 2024
PR-URL: #52659 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
marco-ippolito pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52659 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Merged
marco-ippolito pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52659 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes several invalid jsdoc declarations